Enable VPC Endpoint and Target Group cleaning#10
Merged
mfbonfigli merged 1 commit intoMar 30, 2026
Merged
Conversation
mtulio
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Enables the Janitor to cleanup VPC Endpoints and Load Balancer Target Groups.
VPC Endpoints (VPCE)
VPC Endpoint cleanup is enabled because most Openshift installations appear to configure a VPC Endpoint for S3 by default. Without enabling the VPCE cleanup, the Janitor won't be able to fully delete these VPCs and the deletion fails with error related to a leftover a dependent resource (the VPCE).
Target Groups
Load balancers are tied to the EC2s they distribute the traffic to via Target Groups. The Janitor currently deletes Load Balancers, but leaves leftover Target Groups which have little to no use. The change enables their cleanup to avoid them building up in the region for no reason.