Skip to content

Add missing ec2 permissions and target ec2 stopped instances #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvanderp3 merged 1 commit into from
Mar 27, 2026
+6 −1
Merged

Add missing ec2 permissions and target ec2 stopped instances #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws-janitor/resources/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (Instances) MarkAndSweep(opts Options, set *Set) error {
Filters: []ec2types.Filter{
{
Name: aws2.String("instance-state-name"),
Values: []string{"running", "pending"},
Values: []string{"running", "pending", "stopped"},
},
},
}
Expand Down
5 changes: 5 additions & 0 deletions infra/infra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ func NewAwsJanitorStack(scope constructs.Construct, id string, props *AwsJanitor
jsii.String("ec2:DisassociateAddress"),
jsii.String("ec2:ReleaseAddress"),
jsii.String("ec2:TerminateInstances"),
jsii.String("ec2:RevokeSecurityGroupIngress"),
jsii.String("ec2:RevokeSecurityGroupEgress"),
jsii.String("ec2:DetachInternetGateway"),
jsii.String("ec2:AssociateDhcpOptions"),
jsii.String("ec2:DisassociateRouteTable"),

// ELB permissions
jsii.String("elasticloadbalancing:Describe*"),
Expand Down
Loading