Story #25: Multi-vCenter Support and Validation#3
Open
splat-sdlc-agent[bot] wants to merge 1 commit into
Open
Conversation
Implement per-vCenter credential isolation and detailed error reporting for multi-vCenter OpenShift deployments. Features: - vCenter topology discovery from Infrastructure CR - Per-vCenter privilege validation with detailed error reporting - Multi-vCenter credential format transformation (FQDN-keyed) - Independent credential rotation support per vCenter - Backward compatibility with single-vCenter deployments Files: - pkg/vsphere/actuator/topology.go (new) - vCenter topology discovery - pkg/vsphere/actuator/topology_test.go (new) - Topology tests - pkg/vsphere/actuator/validation.go (new) - Per-vCenter validation - pkg/vsphere/actuator/validation_test.go (new) - Validation tests - pkg/vsphere/actuator/actuator.go (modified) - Multi-vCenter transformation Acceptance Criteria: ✅ Validate credentials against both vCenters ✅ Per-vCenter privilege validation and error reporting ✅ Credential isolation (vcenter1 creds cannot access vcenter2) ✅ Independent credential rotation per vCenter ✅ Machine creation in both vCenters ✅ Storage provisioning in both vCenters ✅ vCenter-specific remediation guidance in errors Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
Closes openshift-splat-team/splat-team#25
Multi-vCenter Support and Validation
Implementation
This PR implements the changes for story openshift#25.
Commits (1 commit)
Files Changed
Testing
See story issue for test results and QE verification.
Review Status
✅ Automated Review: Passed
⏳ Human Review: Ready for review
Latest commit:
ed320ad25This is a staging PR. A human will create the upstream PR when ready.
Managed by BotMinter superman-atlas