Skip to content

feat: add vsphere-component annotation to CredentialsRequest CR (story #39)#4

Open
splatypus-bot wants to merge 1 commit into
mainfrom
story-39-vsphere-component-annotation
Open

feat: add vsphere-component annotation to CredentialsRequest CR (story #39)#4
splatypus-bot wants to merge 1 commit into
mainfrom
story-39-vsphere-component-annotation

Conversation

@splatypus-bot
Copy link
Copy Markdown

Summary

  • Adds cloudcredential.openshift.io/vsphere-component: cloudController annotation to the openshift-vsphere-cloud-controller-manager CredentialsRequest CR
  • Annotation is backward-compatible: CCO ignores it in Passthrough mode (default)
  • Adds manifest annotation unit tests in test/manifest/

Test plan

GOFLAGS=-mod=vendor go test ./test/manifest/... -v

All 2 tests pass:

  • TestCCMVSphereCredentialsRequestAnnotation
  • TestAnnotationValueIsNotEmpty

References

🤖 Generated with Claude Code

Add cloudcredential.openshift.io/vsphere-component: cloudController to
openshift-vsphere-cloud-controller-manager CredentialsRequest so CCO
can route per-component credentials in PerComponent mode (story openshift#39).

Add manifest annotation unit tests (test/manifest/).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Warning

Rate limit exceeded

@splatypus-bot has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 16 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f0fe176a-ea3a-49b0-bf38-abb8b58213fe

📥 Commits

Reviewing files that changed from the base of the PR and between 1eccfe3 and 84edf42.

📒 Files selected for processing (2)
  • manifests/0000_26_cloud-controller-manager-operator_17_credentialsrequest-vsphere.yaml
  • test/manifest/credentials_request_annotation_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch story-39-vsphere-component-annotation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@splatypus-bot
Copy link
Copy Markdown
Author

💻 dev — 2026-05-12T18:05:27Z

PR Feedback Analysis

Reviewed PR for feedback from @coderabbitai. The only comment is a rate limit notification from 2026-05-09, which is not actionable review feedback - it's an auto-generated message indicating CodeRabbit couldn't perform a review due to usage limits.

Story Status: Story openshift#39 completed the full workflow and was closed on 2026-05-11:

  • ✅ dev:code-review (APPROVED 2026-05-09)
  • ✅ qe:verify (APPROVED 2026-05-09)
  • ✅ arch:sign-off (2026-05-09)
  • ✅ po:merge → done (2026-05-09)

Implementation:

  • YAML annotation added to manifests/0000_26_cloud-controller-manager-operator_17_credentialsrequest-vsphere.yaml
  • Unit tests added in test/manifest/credentials_request_annotation_test.go
  • All tests passing

No further action required on this PR.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Review rate limit: 1/1 review remaining, available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant