Skip to content

feat: add vsphere-component annotation to CredentialsRequest CRs (story #39)#4

Open
splatypus-bot wants to merge 1 commit into
mainfrom
story-39-vsphere-component-annotation
Open

feat: add vsphere-component annotation to CredentialsRequest CRs (story #39)#4
splatypus-bot wants to merge 1 commit into
mainfrom
story-39-vsphere-component-annotation

Conversation

@splatypus-bot
Copy link
Copy Markdown

Summary

  • Adds cloudcredential.openshift.io/vsphere-component: csiDriver to openshift-vmware-vsphere-csi-driver-operator CredentialsRequest
  • Adds cloudcredential.openshift.io/vsphere-component: vsphereProblemDetector to openshift-vsphere-problem-detector CredentialsRequest
  • Annotation value vsphereProblemDetector (not diagnostics) matches CCO componentSecretName() routing key in story [release-4.1] Bug 1717640: Add related objects to Status openshift/cluster-storage-operator#38's implementation
  • Annotation is backward-compatible: CCO ignores it in Passthrough mode (default)
  • Adds manifest annotation unit tests in test/manifest/

Test plan

GOFLAGS=-mod=vendor go test ./test/manifest/... -v

All 3 tests pass:

  • TestCSOCSIVSphereCredentialsRequestAnnotation
  • TestCSODetectorVSphereCredentialsRequestAnnotation
  • TestAnnotationValuesAreNotEmpty

References

🤖 Generated with Claude Code

Add cloudcredential.openshift.io/vsphere-component annotations:
- openshift-vmware-vsphere-csi-driver-operator: csiDriver
- openshift-vsphere-problem-detector: vsphereProblemDetector

Annotation value for problem-detector uses vsphereProblemDetector (not
diagnostics) to match CCO credential_distribution.go routing key (story openshift#38/openshift#39).

Add manifest annotation unit tests (test/manifest/).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Warning

Rate limit exceeded

@splatypus-bot has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 962cea12-f170-4895-834d-f8cb8a55e133

📥 Commits

Reviewing files that changed from the base of the PR and between 8dfdf2e and 858b0c5.

📒 Files selected for processing (3)
  • manifests/03_credentials_request_vsphere_csi.yaml
  • manifests/03_credentials_request_vsphere_detector.yaml
  • test/manifest/credentials_request_annotation_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch story-39-vsphere-component-annotation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@splatypus-bot
Copy link
Copy Markdown
Author

💻 dev — 2026-05-12T18:10:25Z

The CodeRabbit rate limit notification is not actionable review feedback. Story openshift#39 is already complete and closed. All implementation work for this story was finished on 2026-05-11.

No further action required on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant