csv-generator: Populate name field in relatedImages entries#163
Merged
tiraboschi merged 1 commit intoopenshift-virtualization:mainfrom May 8, 2026
Merged
Conversation
The relatedImages section was generating entries with only the image field populated, leaving the name field empty. This caused issues when merging CSVs in the HCO bundle build pipeline, where entries appeared with 'name: ""' in the final CSV. The HCO CSV format expects both image and name fields to be set to the same value for each relatedImages entry. This ensures consistency across all operator CSVs and prevents empty name fields in the merged output. Assisted by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Nir Dothan <ndothan@redhat.com>
0a738cc to
934707b
Compare
Contributor
Author
|
/cc @tiraboschi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
relatedImagesgeneration to populate bothimageandnamefields, preventing empty name entries in the merged HCO CSV.Problem
The
buildRelatedImages()function introduced in #158 was creatingRelatedImageentries with only theimagefield populated, leaving thenamefield empty:When the HCO bundle merge-manifests task combined all operator CSVs, this resulted in entries with
name: ""in the final CSV, which is inconsistent with the expected HCO CSV format.Solution
Updated
buildRelatedImages()to set theNamefield to the same value as theImagefield for both the operator image and all additional images:This ensures consistency across all operator CSVs in the HCO bundle.
Changes
buildRelatedImages()incmd/csv-generator/main.goto populate theNamefieldcmd/csv-generator/related_images_test.goto verify the correct behaviorTesting
All existing tests pass with the updated expectations.