MGMT-23709: Clean up temp directories after building ISOs#680
MGMT-23709: Clean up temp directories after building ISOs#680zaneb wants to merge 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request references MGMT-23709 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Test is failing due to https://redhat.atlassian.net/browse/OCPBUGS-81295, but it's getting comfortably past the image building stage. |
|
/cc @pawanpinjarkar |
|
/test e2e-agent-compact-ipv4-iso-no-registry |
Add a new --preserve-temp-dirs command-line flag to optionally preserve temporary work directories after ISO creation. This helps developers debug build issues by inspecting intermediate artifacts like CoreOS ISO contents, split data chunks, and registry images. The flag: - Is a persistent flag available to all build subcommands - Defaults to false (cleanup enabled by default) - Controls cleanup in two locations: - Live ISO work directory (/temp/live-iso-*) - Data staging directory (/temp/data/) - Logs informational messages when directories are preserved When the flag is set, the build process logs which directories are preserved instead of cleaning them up. Assisted-by: Claude Code
The work directory (/temp/live-iso-*/) contains the extracted CoreOS ISO files and split data.iso chunks. Once appliance.iso is successfully created from these files, the work directory serves no further purpose. Remove the work directory immediately after appliance.iso creation to reduce disk usage during builds. This eliminates another large temporary copy of data. Assisted-by: Claude Code
The staging directory (/temp/data/) is only needed as an intermediate location for genisoimage to create data.iso. Once the ISO is successfully generated in the cache, the staging directory serves no further purpose. Remove the staging directory immediately after data.iso creation to reduce disk usage during builds. This eliminates one unnecessary copy of the registry data. Assisted-by: Claude Code
|
@zaneb: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
No description provided.