NO-ISSUE: [master] Bump OCP versions: 4.20, 4.18, 4.22#10139
NO-ISSUE: [master] Bump OCP versions: 4.20, 4.18, 4.22#10139danmanor wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@danmanor: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughUpdates RHCOS pre-release ISO URLs from 4.22.0-ec.3 to 4.22.0-ec.5 and bumps OpenShift release image versions (4.18→4.18.37, 4.20→4.20.18) across multiple configuration and data files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
data/default_os_images.json (1)
237-257:⚠️ Potential issue | 🟠 MajorUpdate the 4.22 arm64 RHCOS ISO to
ec.5too.Line 245 still points at
4.22.0-ec.3, leaving the 4.22 OS-image catalog inconsistent across architectures. This PR already updates the 4.22 arm64 release image toec.5(visible indata/default_release_images.json), confirmingec.5is the correct version for arm64.After fixing this block, re-sync the duplicated OS-image arrays in:
config/manager/manager.yamldeploy/podman/configmap.ymlopenshift/template.yamlconfig/samples/agent-install.openshift.io_v1beta1_agentserviceconfig.yamldeploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yamlSuggested patch
{ "openshift_version": "4.22", "cpu_architecture": "arm64", - "url": "https://mirror.openshift.com/pub/openshift-v4/aarch64/dependencies/rhcos/pre-release/4.22.0-ec.3/rhcos-4.22.0-ec.3-aarch64-live-iso.aarch64.iso", + "url": "https://mirror.openshift.com/pub/openshift-v4/aarch64/dependencies/rhcos/pre-release/4.22.0-ec.5/rhcos-4.22.0-ec.5-aarch64-live-iso.aarch64.iso", "version": "9.6.20251023-0" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@data/default_os_images.json` around lines 237 - 257, The arm64 RHCOS entry for openshift_version "4.22" (the JSON object with "cpu_architecture": "arm64" whose "url" currently contains "4.22.0-ec.3") must be updated to use the ec.5 ISO URL (change "ec.3" to "ec.5") and keep the "version" value unchanged; after updating that JSON object, re-sync the duplicated OS-image arrays across the other manifests so all architectures for 4.22 consistently reference the ec.5 images.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@data/default_os_images.json`:
- Around line 237-257: The arm64 RHCOS entry for openshift_version "4.22" (the
JSON object with "cpu_architecture": "arm64" whose "url" currently contains
"4.22.0-ec.3") must be updated to use the ec.5 ISO URL (change "ec.3" to "ec.5")
and keep the "version" value unchanged; after updating that JSON object, re-sync
the duplicated OS-image arrays across the other manifests so all architectures
for 4.22 consistently reference the ec.5 images.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7305b62b-afa5-49ec-be4a-efb8a30706c0
📒 Files selected for processing (7)
config/manager/manager.yamlconfig/samples/agent-install.openshift.io_v1beta1_agentserviceconfig.yamldata/default_os_images.jsondata/default_release_images.jsondeploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yamldeploy/podman/configmap.ymlopenshift/template.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10139 +/- ##
=======================================
Coverage 44.29% 44.29%
=======================================
Files 415 415
Lines 72713 72713
=======================================
Hits 32205 32205
Misses 37598 37598
Partials 2910 2910 🚀 New features to boost your workflow:
|
|
@danmanor: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing as duplicate of #10146 |
OpenShift updates: 4.20.17-multi -> 4.20.18-multi, 4.18.36 -> 4.18.37, 4.18.36-multi -> 4.18.37-multi, 4.20.17 -> 4.20.18, 4.22.0-ec.4-multi -> 4.22.0-ec.5-multi, 4.22.0-ec.4 -> 4.22.0-ec.5
RHCOS updates: 4.22.0-ec.3 -> 4.22.0-ec.5
/test edge-e2e-metal-assisted-4-20 edge-e2e-metal-assisted-4-18 edge-e2e-metal-assisted-4-22
/cc @rccrdpccl @gamli75
Summary by CodeRabbit
New Features
Updates