NE-2801: Add aws-load-balancer-operator.v1.3.1 and v1.3.2 bundles to FBCs#304
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe catalog templates and generated catalogs for v4.19, v4.20, v4.21, and v4.22 extend the 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (12)
catalog/v4.21/catalog.yaml (3)
254-254: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winSpelling regression: "installated" → "installed" (same as v4.19).
Also applies to: 485-485
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.21/catalog.yaml` at line 254, Fix the spelling regression in the catalog description text by changing “installated” to “installed” in the affected catalog entry, matching the wording already used in v4.19. Update the same phrasing in the other referenced occurrence as well, so the text in the catalog stays consistent and correctly spelled.
1275-1275: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftNew v1.3.1 bundle references staging registry (same as v4.19).
Also applies to: 1461-1462
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.21/catalog.yaml` at line 1275, The bundle image reference in the catalog still points to the staging registry, which should be corrected in the affected entries. Update the image field(s) for the v1.3.1 bundle in the catalog data to use the proper non-staging registry reference, and make the same change for the additional referenced locations so all matching bundle entries stay consistent. Use the existing bundle image definition in the catalog YAML to locate and replace the registry string.
277-277: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winExisting bundle link URLs regressed to placeholder
.domain(same as v4.19).Also applies to: 508-508, 690-690, 878-878, 1066-1066, 1256-1256
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.21/catalog.yaml` at line 277, The bundle link URLs in catalog YAML have regressed to placeholder .domain values. Update the affected url entries in the catalog manifest to the real bundle link hostnames instead of the placeholder, and make sure the same correction is applied consistently across the other referenced occurrences in this file.catalog/v4.20/catalog.yaml (3)
277-277: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winExisting bundle link URLs regressed to
https://aws-load-balancer-operator.domain(same as v4.19).Restore the original GitHub URLs for these already-shipped bundles.
Also applies to: 508-508, 690-690, 878-878, 1066-1066, 1256-1256
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.20/catalog.yaml` at line 277, The bundle link URLs for already-shipped catalog entries were accidentally regressed to the placeholder aws-load-balancer-operator.domain value. Update the affected url fields in catalog.yaml back to the original GitHub release links for each shipped bundle, using the surrounding bundle entries to identify the matching URLs at the referenced locations.
1275-1275: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftNew v1.3.1 bundle references staging registry (same as v4.19).
Confirm the production digest before release.
Also applies to: 1461-1462
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.20/catalog.yaml` at line 1275, The bundle image reference is still pointing at the staging registry, so update the image digest to the confirmed production value before release in the catalog entry that uses the bundle image reference. Make the same correction for the additional matching entries noted in the review, and use the bundle image symbols in the catalog YAML to locate all affected references.
254-254: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winSpelling regression: "installated" → "installed" (same as v4.19).
Restore the correct spelling in these existing bundle descriptions.
Also applies to: 485-485
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.20/catalog.yaml` at line 254, Fix the spelling regression in the bundle descriptions by changing the wording in the catalog entries from “installated” back to “installed.” Update the affected description text in the catalog content so it matches the correct wording used in v4.19, including the other referenced occurrence in the same section.catalog/v4.20/catalog-template.yaml (1)
85-87: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftStage registry reference — same concern as v4.19 template.
The new
v1.3.1bundle usesregistry.stage.redhat.iowhile all other bundles useregistry.redhat.io. Verify this is the intended production digest before merging into the released catalog.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.20/catalog-template.yaml` around lines 85 - 87, The aws-load-balancer-operator.v1.3.1 bundle in the catalog-template is pointing at registry.stage.redhat.io while the other bundles use the production registry. Update the image reference in the aws-load-balancer-operator bundle entry to the intended registry.redhat.io digest, or confirm and document that the stage reference is deliberate before merging.catalog/v4.22/catalog.yaml (3)
1275-1275: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftNew v1.3.1 bundle references staging registry (same as v4.19).
Also applies to: 1461-1462
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.22/catalog.yaml` at line 1275, The bundle image reference in the catalog entry is still pointing at the staging registry, so update the image used by this package entry to the correct non-staging registry value. Make the same registry fix in the related catalog entries referenced by the comment, and verify the bundle reference in the catalog YAML is consistent with the intended release stream.
254-254: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winSpelling regression: "installated" → "installed" (same as v4.19).
Also applies to: 485-485
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.22/catalog.yaml` at line 254, There is a spelling regression in the catalog text where “installated” should be “installed”; update the affected strings in the catalog content so the wording matches the correct spelling used previously, including the related entry referenced by the same comment. Use the surrounding catalog text to locate the affected sentence and keep the rest of the wording unchanged.
277-277: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winExisting bundle link URLs regressed to placeholder
.domain(same as v4.19).Also applies to: 508-508, 690-690, 878-878, 1066-1066, 1256-1256
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.22/catalog.yaml` at line 277, The bundle link URLs in the catalog YAML have regressed to the placeholder aws-load-balancer-operator.domain, so update the affected bundle entries back to the real AWS Load Balancer Operator URL. Check the repeated URL fields in the catalog manifest across the referenced bundle sections, and replace each placeholder value consistently so the links match the non-placeholder pattern used in other releases.catalog/v4.22/catalog-template.yaml (1)
85-87: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftStage registry reference — same concern as other templates.
registry.stage.redhat.ioforv1.3.1; verify intended production digest before release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.22/catalog-template.yaml` around lines 85 - 87, The bundle reference in the catalog template still points to the stage registry for aws-load-balancer-operator.v1.3.1. Update the image field in the catalog entry to the intended production registry digest, and verify the digest matches the release artifact before publishing; use the existing bundle entry and its image/name/schema fields to locate it.catalog/v4.21/catalog-template.yaml (1)
85-87: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftStage registry reference — same concern as other templates.
registry.stage.redhat.iofor the newv1.3.1bundle; verify intended production digest.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@catalog/v4.21/catalog-template.yaml` around lines 85 - 87, The aws-load-balancer-operator bundle entry in catalog-template.yaml is still pointing at the stage registry reference, so update the image in the aws-load-balancer-operator.v1.3.1 bundle definition to the intended production registry/digest used by the other templates and verify the digest is correct before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@catalog/v4.19/catalog-template.yaml`:
- Around line 85-87: The aws-load-balancer-operator.v1.3.1 bundle entry is still
using a staged registry image, so update the bundle reference in the catalog
template to the production registry image. Make the change in the
aws-load-balancer-operator.v1.3.1 catalog entry and apply the same
registry.redhat.io replacement anywhere this staged bundle reference appears in
the v4.19–v4.22 catalog templates/generated catalogs to keep them consistent.
In `@catalog/v4.19/catalog.yaml`:
- Line 277: The published bundle link URLs in the existing catalog entries were
replaced with an invalid placeholder domain, so restore the original
`links[].url` values in the affected bundle definitions to the correct GitHub
URL used by the shipped bundles. Update the bundle metadata in
`catalog/v4.19/catalog.yaml` for the entries matching v1.0.0–v1.3.0, using the
same URL format already present in the v1.3.1 bundle, and verify the `url` field
under each affected bundle remains consistent with the original source content.
- Line 254: The bundle description text in catalog generation has a spelling
regression: “installated” should be “installed”. Update the published bundle
text in the generated catalog output so it matches the intended description, and
make the same correction wherever the same typo appears in the rendered bundle
content, including the matching description entry in the catalog generation
path.
- Line 1275: The aws-load-balancer-operator.v1.3.1 bundle image in
catalog/v4.19/catalog.yaml still points to the staging registry; update the
image reference for the v1.3.1 entries to use the production registry.redhat.io
bundle image instead of registry.stage.redhat.io. Make the change consistently
wherever the v1.3.1 bundle is declared so the catalog points to the
release-ready image.
---
Duplicate comments:
In `@catalog/v4.20/catalog-template.yaml`:
- Around line 85-87: The aws-load-balancer-operator.v1.3.1 bundle in the
catalog-template is pointing at registry.stage.redhat.io while the other bundles
use the production registry. Update the image reference in the
aws-load-balancer-operator bundle entry to the intended registry.redhat.io
digest, or confirm and document that the stage reference is deliberate before
merging.
In `@catalog/v4.20/catalog.yaml`:
- Line 277: The bundle link URLs for already-shipped catalog entries were
accidentally regressed to the placeholder aws-load-balancer-operator.domain
value. Update the affected url fields in catalog.yaml back to the original
GitHub release links for each shipped bundle, using the surrounding bundle
entries to identify the matching URLs at the referenced locations.
- Line 1275: The bundle image reference is still pointing at the staging
registry, so update the image digest to the confirmed production value before
release in the catalog entry that uses the bundle image reference. Make the same
correction for the additional matching entries noted in the review, and use the
bundle image symbols in the catalog YAML to locate all affected references.
- Line 254: Fix the spelling regression in the bundle descriptions by changing
the wording in the catalog entries from “installated” back to “installed.”
Update the affected description text in the catalog content so it matches the
correct wording used in v4.19, including the other referenced occurrence in the
same section.
In `@catalog/v4.21/catalog-template.yaml`:
- Around line 85-87: The aws-load-balancer-operator bundle entry in
catalog-template.yaml is still pointing at the stage registry reference, so
update the image in the aws-load-balancer-operator.v1.3.1 bundle definition to
the intended production registry/digest used by the other templates and verify
the digest is correct before merging.
In `@catalog/v4.21/catalog.yaml`:
- Line 254: Fix the spelling regression in the catalog description text by
changing “installated” to “installed” in the affected catalog entry, matching
the wording already used in v4.19. Update the same phrasing in the other
referenced occurrence as well, so the text in the catalog stays consistent and
correctly spelled.
- Line 1275: The bundle image reference in the catalog still points to the
staging registry, which should be corrected in the affected entries. Update the
image field(s) for the v1.3.1 bundle in the catalog data to use the proper
non-staging registry reference, and make the same change for the additional
referenced locations so all matching bundle entries stay consistent. Use the
existing bundle image definition in the catalog YAML to locate and replace the
registry string.
- Line 277: The bundle link URLs in catalog YAML have regressed to placeholder
.domain values. Update the affected url entries in the catalog manifest to the
real bundle link hostnames instead of the placeholder, and make sure the same
correction is applied consistently across the other referenced occurrences in
this file.
In `@catalog/v4.22/catalog-template.yaml`:
- Around line 85-87: The bundle reference in the catalog template still points
to the stage registry for aws-load-balancer-operator.v1.3.1. Update the image
field in the catalog entry to the intended production registry digest, and
verify the digest matches the release artifact before publishing; use the
existing bundle entry and its image/name/schema fields to locate it.
In `@catalog/v4.22/catalog.yaml`:
- Line 1275: The bundle image reference in the catalog entry is still pointing
at the staging registry, so update the image used by this package entry to the
correct non-staging registry value. Make the same registry fix in the related
catalog entries referenced by the comment, and verify the bundle reference in
the catalog YAML is consistent with the intended release stream.
- Line 254: There is a spelling regression in the catalog text where
“installated” should be “installed”; update the affected strings in the catalog
content so the wording matches the correct spelling used previously, including
the related entry referenced by the same comment. Use the surrounding catalog
text to locate the affected sentence and keep the rest of the wording unchanged.
- Line 277: The bundle link URLs in the catalog YAML have regressed to the
placeholder aws-load-balancer-operator.domain, so update the affected bundle
entries back to the real AWS Load Balancer Operator URL. Check the repeated URL
fields in the catalog manifest across the referenced bundle sections, and
replace each placeholder value consistently so the links match the
non-placeholder pattern used in other releases.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 476105b3-1736-453f-8820-f0a77e518b5a
📒 Files selected for processing (8)
catalog/v4.19/catalog-template.yamlcatalog/v4.19/catalog.yamlcatalog/v4.20/catalog-template.yamlcatalog/v4.20/catalog.yamlcatalog/v4.21/catalog-template.yamlcatalog/v4.21/catalog.yamlcatalog/v4.22/catalog-template.yamlcatalog/v4.22/catalog.yaml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@catalog/v4.17/catalog.yaml`:
- Line 208: The catalog entries are still using the placeholder project URL
instead of the canonical repository URL. Update the generated catalog in the
affected aws-load-balancer-operator CSV/base manifest entries so the url field
matches https://github.com/openshift/aws-load-balancer-operator, and ensure the
same correction is applied consistently to all matching catalog references.
In `@catalog/v4.18/catalog.yaml`:
- Line 208: Restore the canonical project URL in the rendered v4.18 catalog
entries by updating the repeated url fields in catalog/v4.18/catalog.yaml to
match the source ClusterServiceVersion for aws-load-balancer-operator, using the
GitHub project URL from aws-load-balancer-operator.clusterserviceversion.yaml
rather than the placeholder domain. If the catalog is generated, rerun the
catalog generation from the source manifest so all occurrences are corrected
consistently; otherwise update each rendered entry that references the project
URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 76733615-8f89-450b-9b65-afdd986526b7
📒 Files selected for processing (23)
catalog/v4.12/catalog-template.yamlcatalog/v4.12/catalog.yamlcatalog/v4.13/catalog-template.yamlcatalog/v4.13/catalog.yamlcatalog/v4.14/catalog-template.yamlcatalog/v4.14/catalog.yamlcatalog/v4.15/catalog-template.yamlcatalog/v4.15/catalog.yamlcatalog/v4.16/catalog-template.yamlcatalog/v4.16/catalog.yamlcatalog/v4.17/catalog-template.yamlcatalog/v4.17/catalog.yamlcatalog/v4.18/catalog-template.yamlcatalog/v4.18/catalog.yamlcatalog/v4.19/catalog-template.yamlcatalog/v4.19/catalog.yamlcatalog/v4.20/catalog-template.yamlcatalog/v4.20/catalog.yamlcatalog/v4.21/catalog-template.yamlcatalog/v4.21/catalog.yamlcatalog/v4.22/catalog-template.yamlcatalog/v4.22/catalog.yamldocs/versioning.md
💤 Files with no reviewable changes (15)
- catalog/v4.20/catalog-template.yaml
- catalog/v4.19/catalog-template.yaml
- catalog/v4.14/catalog-template.yaml
- catalog/v4.21/catalog-template.yaml
- catalog/v4.22/catalog-template.yaml
- catalog/v4.16/catalog-template.yaml
- catalog/v4.13/catalog-template.yaml
- catalog/v4.15/catalog-template.yaml
- catalog/v4.18/catalog-template.yaml
- catalog/v4.12/catalog-template.yaml
- catalog/v4.21/catalog.yaml
- catalog/v4.17/catalog-template.yaml
- catalog/v4.19/catalog.yaml
- catalog/v4.20/catalog.yaml
- catalog/v4.22/catalog.yaml
✅ Files skipped from review due to trivial changes (1)
- docs/versioning.md
| links: | ||
| - name: Aws Load Balancer Operator | ||
| url: https://github.com/openshift/aws-load-balancer-operator | ||
| url: https://aws-load-balancer-operator.domain |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify whether the placeholder URL is generated from the v4.17 template/source
# or only appears in the regenerated catalog output.
rg -n -C3 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' \
catalog/v4.17/catalog.yaml \
catalog/v4.17/catalog-template.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 4731
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate every occurrence of the placeholder URL and the catalog generation inputs.
git ls-files | rg '(^|/)(catalog|bundle|manifests|config|hack|internal|scripts)/|catalog-template|csv|bundle|operator|olm' >/tmp/cand_files.txt || true
printf '\n== placeholder occurrences ==\n'
rg -n 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' .
printf '\n== likely catalog generation files ==\n'
rg -n 'catalog-template|opm|csv|bundle|render|generate.*catalog|catalog.yaml' \
.github . \
--glob '!catalog/v4.17/catalog.yaml' \
--glob '!**/vendor/**'Repository: openshift/aws-load-balancer-operator
Length of output: 50392
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate every occurrence of the placeholder URL and the catalog generation inputs.
git ls-files | rg '(^|/)(catalog|bundle|manifests|config|hack|internal|scripts)/|catalog-template|csv|bundle|operator|olm' >/tmp/cand_files.txt || true
printf '\n== placeholder occurrences ==\n'
rg -n 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' .
printf '\n== likely catalog generation files ==\n'
rg -n 'catalog-template|opm|csv|bundle|render|generate.*catalog|catalog.yaml' \
.github . \
--glob '!catalog/v4.17/catalog.yaml' \
--glob '!**/vendor/**'Repository: openshift/aws-load-balancer-operator
Length of output: 50392
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the canonical CSV link in the bundle/base manifests and the generated catalog blocks.
sed -n '430,475p' bundle/manifests/aws-load-balancer-operator.clusterserviceversion.yaml
printf '\n---\n'
sed -n '60,90p' config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml
printf '\n---\n'
sed -n '200,215p' catalog/v4.17/catalog.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 2227
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the canonical CSV link in the bundle/base manifests and the generated catalog blocks.
sed -n '430,475p' bundle/manifests/aws-load-balancer-operator.clusterserviceversion.yaml
printf '\n---\n'
sed -n '60,90p' config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml
printf '\n---\n'
sed -n '200,215p' catalog/v4.17/catalog.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 2227
Restore the canonical project URL in the catalog CSV links. catalog/v4.17/catalog.yaml:208, 396, 584 still points to https://aws-load-balancer-operator.domain, but the bundle CSV/base manifest uses https://github.com/openshift/aws-load-balancer-operator; update the generated catalog to match.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@catalog/v4.17/catalog.yaml` at line 208, The catalog entries are still using
the placeholder project URL instead of the canonical repository URL. Update the
generated catalog in the affected aws-load-balancer-operator CSV/base manifest
entries so the url field matches
https://github.com/openshift/aws-load-balancer-operator, and ensure the same
correction is applied consistently to all matching catalog references.
Source: Learnings
| links: | ||
| - name: Aws Load Balancer Operator | ||
| url: https://github.com/openshift/aws-load-balancer-operator | ||
| url: https://aws-load-balancer-operator.domain |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify whether the placeholder URL is generated from the v4.18 template/source
# or only appears in the regenerated catalog output.
rg -n -C3 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' \
catalog/v4.18/catalog.yaml \
catalog/v4.18/catalog-template.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 4731
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the template/source around the catalog link fields and any generated URL placeholders.
for f in catalog/v4.18/catalog-template.yaml catalog/v4.18/catalog.yaml; do
echo "=== $f ==="
rg -n -C2 'links:|name: Aws Load Balancer Operator|url:' "$f"
done
# Find where the placeholder domain is referenced elsewhere in the repo.
rg -n 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' .Repository: openshift/aws-load-balancer-operator
Length of output: 218
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the template/source around the catalog link fields and any generated URL placeholders.
for f in catalog/v4.18/catalog-template.yaml catalog/v4.18/catalog.yaml; do
echo "=== $f ==="
rg -n -C2 'links:|name: Aws Load Balancer Operator|url:' "$f"
done
# Find where the placeholder domain is referenced elsewhere in the repo.
rg -n 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' .Repository: openshift/aws-load-balancer-operator
Length of output: 218
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the template/source around the catalog link fields and any generated URL placeholders.
for f in catalog/v4.18/catalog-template.yaml catalog/v4.18/catalog.yaml; do
echo "=== $f ==="
rg -n -C2 'links:|name: Aws Load Balancer Operator|url:' "$f"
done
# Find where the placeholder domain is referenced elsewhere in the repo.
rg -n 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' .Repository: openshift/aws-load-balancer-operator
Length of output: 218
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the template/source around the catalog link fields and any generated URL placeholders.
for f in catalog/v4.18/catalog-template.yaml catalog/v4.18/catalog.yaml; do
echo "=== $f ==="
rg -n -C2 'links:|name: Aws Load Balancer Operator|url:' "$f"
done
# Find where the placeholder domain is referenced elsewhere in the repo.
rg -n 'aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator' .Repository: openshift/aws-load-balancer-operator
Length of output: 218
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Map the catalog/v4.18 area and inspect likely source files for the generated link.
git ls-files 'catalog/v4.18/*' 'catalog/*' | sed -n '1,200p'
echo '--- catalog/v4.18/catalog-template.yaml ---'
wc -l catalog/v4.18/catalog-template.yaml || true
sed -n '1,260p' catalog/v4.18/catalog-template.yaml || true
echo '--- catalog/v4.18/catalog.yaml relevant excerpt ---'
sed -n '200,214p;388,402p;580,590p' catalog/v4.18/catalog.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 16444
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Map the catalog/v4.18 area and inspect likely source files for the generated link.
git ls-files 'catalog/v4.18/*' 'catalog/*' | sed -n '1,200p'
echo '--- catalog/v4.18/catalog-template.yaml ---'
wc -l catalog/v4.18/catalog-template.yaml || true
sed -n '1,260p' catalog/v4.18/catalog-template.yaml || true
echo '--- catalog/v4.18/catalog.yaml relevant excerpt ---'
sed -n '200,214p;388,402p;580,590p' catalog/v4.18/catalog.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 16444
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find where the catalog is generated from and whether the URL is templated elsewhere.
rg -n 'catalog-template|catalog\.yaml|aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator|link' \
.github catalog config hack scripts makefile* Makefile* . \
-g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**'Repository: openshift/aws-load-balancer-operator
Length of output: 50393
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find the source of the catalog generation and any URL/template substitutions.
rg -n 'catalog-template|catalog\.yaml|aws-load-balancer-operator\.domain|github\.com/openshift/aws-load-balancer-operator|name: Aws Load Balancer Operator|url:' \
.github hack scripts config catalog Makefile* makefile* \
-g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**'Repository: openshift/aws-load-balancer-operator
Length of output: 15721
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the bundle CSV source and the generated catalog entries for the link target.
echo '--- catalog/aws-load-balancer-operator/bundle.yaml (links) ---'
rg -n -C3 'links:|name: Aws Load Balancer Operator|url:' catalog/aws-load-balancer-operator/bundle.yaml
echo '--- config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml (links) ---'
rg -n -C3 'links:|name: Aws Load Balancer Operator|url:' config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml
echo '--- catalog/v4.18/catalog.yaml (all link urls) ---'
rg -n -C2 'name: Aws Load Balancer Operator|url:' catalog/v4.18/catalog.yaml | sed -n '1,40p'Repository: openshift/aws-load-balancer-operator
Length of output: 237
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the bundle CSV source and the generated catalog entries for the link target.
echo '--- catalog/aws-load-balancer-operator/bundle.yaml (links) ---'
rg -n -C3 'links:|name: Aws Load Balancer Operator|url:' catalog/aws-load-balancer-operator/bundle.yaml
echo '--- config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml (links) ---'
rg -n -C3 'links:|name: Aws Load Balancer Operator|url:' config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml
echo '--- catalog/v4.18/catalog.yaml (all link urls) ---'
rg -n -C2 'name: Aws Load Balancer Operator|url:' catalog/v4.18/catalog.yaml | sed -n '1,40p'Repository: openshift/aws-load-balancer-operator
Length of output: 237
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the source CSV and bundle to trace the catalog link target.
echo '=== config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml ==='
rg -n -C4 'links:|name: Aws Load Balancer Operator|url:' config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml || true
echo '=== catalog/aws-load-balancer-operator/bundle.yaml ==='
rg -n -C4 'links:|name: Aws Load Balancer Operator|url:' catalog/aws-load-balancer-operator/bundle.yaml || true
echo '=== catalog/v4.18/catalog.yaml ==='
rg -n -C3 'name: Aws Load Balancer Operator|url: https://aws-load-balancer-operator\.domain|url: https://github\.com/openshift/aws-load-balancer-operator' catalog/v4.18/catalog.yamlRepository: openshift/aws-load-balancer-operator
Length of output: 1334
Restore the canonical project URL in the v4.18 catalog. catalog/v4.18/catalog.yaml still shows https://aws-load-balancer-operator.domain at lines 208, 396, and 584, while the source CSV uses https://github.com/openshift/aws-load-balancer-operator in config/manifests/bases/aws-load-balancer-operator.clusterserviceversion.yaml:73-75. Regenerate the catalog from that source or update the rendered entries directly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@catalog/v4.18/catalog.yaml` at line 208, Restore the canonical project URL in
the rendered v4.18 catalog entries by updating the repeated url fields in
catalog/v4.18/catalog.yaml to match the source ClusterServiceVersion for
aws-load-balancer-operator, using the GitHub project URL from
aws-load-balancer-operator.clusterserviceversion.yaml rather than the
placeholder domain. If the catalog is generated, rerun the catalog generation
from the source manifest so all occurrences are corrected consistently;
otherwise update each rendered entry that references the project URL.
Source: Learnings
Add the `v1.3.1` bundle from stage release to FBC catalog templates (`v4.19`-`v4.22`) and regenerate catalogs. Bundle digest: `sha256:5175d8c7c3b9936674eb30938fc5d744a0e665ad9f335f7d73e81938debb41b0` Co-Authored-By: Claude
Remove the deprecated `aws-load-balancer-operator.v1.0.0` and `aws-load-balancer-operator.v1.0.1` bundles, the `stable-v1.0` channel, and the associated `olm.deprecations` entries from all FBC catalog templates (`v4.12`-`v4.22`). The `v1.0.x` bundles have been deprecated since the FBCs were first introduced in December 2025. Co-Authored-By: Claude
Add `olm.deprecations` entries for the `stable-v1.1` channel, `aws-load-balancer-operator.v1.1.0`, and `aws-load-balancer-operator.v1.1.1` bundles in all FBC catalog templates (`v4.12`-`v4.22`). Co-Authored-By: Claude
Co-Authored-By: Claude
alebedev87
changed the title
aws-load-balancer-operator.v1.3.1 bundle to FBCsaws-load-balancer-operator.v1.3.1 and v1.3.2 bundles to FBCs
Contributor
Author
|
/test ci-index-aws-load-balancer-operator-bundle-index |
alebedev87
changed the title
aws-load-balancer-operator.v1.3.1 and v1.3.2 bundles to FBCsaws-load-balancer-operator.v1.3.1 and v1.3.2 bundles to FBCs
openshift-ci-robot
added
the
jira/valid-reference
|
@alebedev87: This pull request references NE-2801 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/test ci-index-aws-load-balancer-operator-bundle |
Contributor
Author
|
/test ci-bundle-aws-load-balancer-operator-bundle |
Contributor
Author
|
/approve |
Contributor
Author
|
/override ci/prow/e2e-aws-rosa-operator |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
@alebedev87: Overrode contexts on behalf of alebedev87: ci/prow/e2e-aws-rosa-operator DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.3.1andv1.3.2bundles to FBC catalog templates (v4.19-v4.22) and regenerate catalogsv1.3.1:sha256:5175d8c7c3b9936674eb30938fc5d744a0e665ad9f335f7d73e81938debb41b0v1.3.2:sha256:c1aecbdb1fd4f4e7ead8e7093dcf5d92b712a4cfb023aadbe63bccc39512fb09v4.12-v4.18are not modified asv1.3.xwas intentionally removed from those per OCPBUGS-76850v1.0.xbundles,stable-v1.0channel, andolm.deprecationsentries from all FBCs (v4.12-v4.22)stable-v1.1channel andv1.1.xbundles in all FBCs (v4.12-v4.22)