SREP-3384: update backplane-cli to allow remediations on infrastructu…

[rolandmkunkel]

…re clusters

What type of PR is this?

• fix (Bug Fix)
• feat (New Feature)
• docs (Documentation)
• test (Test Coverage)
• chore (Clean Up / Maintenance Tasks)
• other (Anything that doesn't fit the above)

What this PR does / Why we need it?

The newer version of backplane-api added support for a ManagingCluster parameter in the remediation creation API, which is necessary for infrastructure clusters. These changes allows passing additional optional parameters like ManagingCluster for infrastructure clusters, while maintaining backward compatibility. This allows CAD to create remediations on infra clusters, as it uses this code as a library.

Which Jira/Github issue(s) does this PR fix?

• Related Issue #
• Closes SREP-3384

Special notes for your reviewer

Unit Test Coverage

Guidelines

• If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
• If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

• Added unit tests
• Created jira card to add unit test
• This PR may not need unit tests

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR
• Backward compatible

/label tide/merge-method-squash

[openshift-ci-robot]

@rolandmkunkel: This pull request references SREP-3384 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

…re clusters

What type of PR is this?

• fix (Bug Fix)
• feat (New Feature)
• docs (Documentation)
• test (Test Coverage)
• chore (Clean Up / Maintenance Tasks)
• other (Anything that doesn't fit the above)

What this PR does / Why we need it?

The newer version of backplane-api added support for a ManagingCluster parameter in the remediation creation API, which is necessary for infrastructure clusters. These changes allows passing additional optional parameters like ManagingCluster for infrastructure clusters, while maintaining backward compatibility. This allows CAD to create remediations on infra clusters, as it uses this code as a library.

Which Jira/Github issue(s) does this PR fix?

• Related Issue #
• Closes SREP-3384

Special notes for your reviewer

Unit Test Coverage

Guidelines

• If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
• If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

• Added unit tests
• Created jira card to add unit test
• This PR may not need unit tests

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR
• Backward compatible

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rolandmkunkel
Once this PR has been reviewed and has the lgtm label, please assign smarthall for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rolandmkunkel: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.91%. Comparing base (62a772a) to head (cebb6bc).

Files with missing lines	Patch %	Lines
pkg/remediation/remediation.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   52.91%   52.91%           
=======================================
  Files          86       86           
  Lines        6525     6525           
=======================================
  Hits         3453     3453           
  Misses       2610     2610           
  Partials      462      462           

Files with missing lines	Coverage Δ
cmd/ocm-backplane/remediation/remediation.go	70.28% <100.00%> (ø)
pkg/remediation/remediation.go	30.95% <50.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.