Skip to content

DNM - Fwup testing telco#454

Open
iurygregory wants to merge 2 commits intoopenshift:release-4.21from
iurygregory:fwup-testing-telco
Open

DNM - Fwup testing telco#454
iurygregory wants to merge 2 commits intoopenshift:release-4.21from
iurygregory:fwup-testing-telco

Conversation

@iurygregory
Copy link

No description provided.

Currently, the controller does not save the status if only the
generation changes, leading to an observed generation mismatch on the
ChangeDetected condition.

Meanwhile, the servicing code assumes that there are no updates when
generations mismatch, even if the condition is true.

This patch fixes the controller and makes the servicing code retry
if generations do not match.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@openshift-ci openshift-ci bot requested review from dtantsur and zaneb February 3, 2026 16:33
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iurygregory
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@iurygregory: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants