Skip to content

OCPBUGS-66071: Fix PPI for ACM#456

Open
iurygregory wants to merge 1 commit intoopenshift:mainfrom
iurygregory:OCPBUGS-66071
Open

OCPBUGS-66071: Fix PPI for ACM#456
iurygregory wants to merge 1 commit intoopenshift:mainfrom
iurygregory:OCPBUGS-66071

Conversation

@iurygregory
Copy link

@iurygregory iurygregory commented Feb 6, 2026

This reverts the changes made in a6ac8a5 because it prevents the creation of a PPI when inspection is disabled and can cause HFS to not be applied.

This reverts the changes made in a6ac8a5
because it prevents the creation of a PPI

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 6, 2026
@openshift-ci-robot
Copy link

@iurygregory: This pull request references Jira Issue OCPBUGS-66071, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts the changes made in a6ac8a5 because it prevents the creation of a PPI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from honza, wangke19 and zaneb February 6, 2026 17:57
@honza
Copy link
Member

honza commented Feb 6, 2026

The commit message should explain how it fixes the problem.

@iurygregory
Copy link
Author

/test e2e-metal-ipi-ovn-ipv6

1 similar comment
@iurygregory
Copy link
Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link

@iurygregory: This pull request references Jira Issue OCPBUGS-66071, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

Details

In response to this:

This reverts the changes made in a6ac8a5 because it prevents the creation of a PPI when inspection was disabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iurygregory
Copy link
Author

The commit message should explain how it fixes the problem.

I've added a bit more detail, but basically we need to revert because in ACM deployments this can block the creation of PPI when inspection is disabled and can cause HFS to not be applied.

@MahnoorAsghar
Copy link

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2026

@iurygregory: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@honza
Copy link
Member

honza commented Feb 17, 2026

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026
@dtantsur
Copy link
Member

dtantsur commented Mar 3, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants