Skip to content

SDN-4773: Add support for Azure Managed Service Identity authentication#151

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
bryan-cox:SDN-4773
Aug 8, 2024
Merged

SDN-4773: Add support for Azure Managed Service Identity authentication#151
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
bryan-cox:SDN-4773

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented Aug 5, 2024

This PR:

  • Adds support for Azure Managed Service Identity authentication
  • Enables Azure MSI override for ARO HCP

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 5, 2024 •
edited by openshift-ci Bot
Loading

@bryan-cox: This pull request references SDN-4773 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

This PR:

  • Adds support for Azure Managed Service Identity authentication
  • Enables Azure MSI override for ARO HCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2024
@openshift-ci openshift-ci Bot requested review from danwinship and kyrtapz August 5, 2024 20:28
kyrtapz
kyrtapz reviewed Aug 6, 2024
View reviewed changes
Comment thread pkg/cloudprovider/azure.go
kyrtapz
kyrtapz reviewed Aug 6, 2024
View reviewed changes
Comment thread pkg/cloudprovider/azure.go Outdated
kyrtapz
kyrtapz reviewed Aug 6, 2024
View reviewed changes
Comment thread pkg/cloudprovider/azure.go
@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 6, 2024

There will need to be a CNO PR setting the AZURE_MSI_AUTHENTICATION env on the CNCC deployment.

@kyrtapz @bryan-cox
Add support for Azure Managed Service Identity authentication
499ae45 
Signed-off-by: Patryk Diak <pdiak@redhat.com>
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Aug 6, 2024

/test e2e-azure-ovn

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Aug 7, 2024

There will need to be a CNO PR setting the AZURE_MSI_AUTHENTICATION env on the CNCC deployment.

@kyrtapz It would just be this right? - openshift/cluster-network-operator#2465

@bryan-cox
Enable Azure MSI override for ARO HCP
7c0636c 
For ARO HCP, we be able to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.
@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 7, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 7, 2024

/test e2e-azure-ovn

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Aug 7, 2024

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 7, 2024

/retest-required

Remaining retests: 0 against base HEAD fc90bb2 and 2 for PR HEAD 7c0636c in total

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Aug 8, 2024

/test e2e-gcp-ovn

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Aug 8, 2024

/retest-required

2 similar comments
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Aug 8, 2024

/retest-required

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 8, 2024

/retest-required

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 8, 2024

e2e-gcp-ovn is failing on image build.
This change is specific to azure and does not affect gcp.
/override e2e-gcp-ovn

@kyrtapz kyrtapz mentioned this pull request Aug 8, 2024
Closed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2024

@kyrtapz: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-ovn

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-serial
  • ci/prow/e2e-azure-ovn
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-openstack-ovn-serial-e2e-only
  • ci/prow/images
  • ci/prow/security
  • ci/prow/unit
  • pull-ci-openshift-cloud-network-config-controller-master-e2e-aws-ovn
  • pull-ci-openshift-cloud-network-config-controller-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cloud-network-config-controller-master-e2e-azure-ovn
  • pull-ci-openshift-cloud-network-config-controller-master-e2e-gcp-ovn
  • pull-ci-openshift-cloud-network-config-controller-master-e2e-openstack-ovn-serial-e2e-only
  • pull-ci-openshift-cloud-network-config-controller-master-images
  • pull-ci-openshift-cloud-network-config-controller-master-security
  • pull-ci-openshift-cloud-network-config-controller-master-unit
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

e2e-gcp-ovn is failing on image build.
This change is specific to azure and does not affect gcp.
/override e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 8, 2024

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2024

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2024

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 7c0636c link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 779b346 into openshift:master Aug 8, 2024
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Aug 8, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-network-config-controller
This PR has been included in build ose-cloud-network-config-controller-container-v4.18.0-202408081219.p0.g779b346.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship Awaiting requested review from danwinship

1 more reviewer

@kyrtapz kyrtapz kyrtapz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kyrtapz kyrtapz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryan-cox @openshift-ci-robot @kyrtapz @openshift-bot