Skip to content

OCPBUGS-42004: Set the Managed Identity client ID#154

Closed
bryan-cox wants to merge 1 commit into
openshift:masterfrom
bryan-cox:HOSTEDCP-1872
Closed

OCPBUGS-42004: Set the Managed Identity client ID#154
bryan-cox wants to merge 1 commit into
openshift:masterfrom
bryan-cox:HOSTEDCP-1872

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

Set the Managed Identity client ID

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 12, 2024

@bryan-cox: This pull request references HOSTEDCP-1872 which is a valid jira issue.

Details

In response to this:

Set the Managed Identity client ID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from abhat and danwinship September 12, 2024 16:18
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox bryan-cox changed the title HOSTEDCP-1872: Set the Managed Identity client ID OCPBUGS-42004: Set the Managed Identity client ID Sep 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 16, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request references Jira Issue OCPBUGS-42004, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @fxierh

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Set the Managed Identity client ID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from fxierh September 16, 2024 13:27
Comment thread pkg/cloudprovider/azure.go
@bryan-cox
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 18, 2024

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1093b16 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Copy Markdown
Member Author

/hold

Microsoft is requesting to not use the sidecar containers.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2024
@bryan-cox
Copy link
Copy Markdown
Member Author

/close

An official decision was made on Monday to not use sidecars to authenticate with Azure. Closing out this PR.

@openshift-ci openshift-ci Bot closed this Oct 9, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request references Jira Issue OCPBUGS-42004. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Set the Managed Identity client ID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 9, 2024

@bryan-cox: Closed this PR.

Details

In response to this:

/close

An official decision was made on Monday to not use sidecars to authenticate with Azure. Closing out this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants