Skip to content

NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7b05e33#834

Open
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest
Open

NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7b05e33#834
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest

Conversation

@red-hat-konflux
Copy link

@red-hat-konflux red-hat-konflux bot commented Feb 25, 2026

This PR contains the following updates:

Package Type Update Change
github.com/openshift/assisted-service/api replace digest 10cee3a -> 7b05e33

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci-robot
Copy link

@red-hat-konflux[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

This PR contains the following updates:

Package Type Update Change
github.com/openshift/assisted-service/api replace digest 10cee3a -> f90427b

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 25, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Updated the go.mod replace directive for github.com/openshift/assisted-service/api to a newer pseudo-version; no module path changes, and no functional/control-flow or error-handling modifications.

Changes

Cohort / File(s) Summary
Dependency Version Update
go.mod
Updated the replace pseudo-version for github.com/openshift/assisted-service/api to v0.0.0-20260228020446-5448b582984b (previously v0.0.0-20260223145238-10cee3a746b9); no other require/replace entries or code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed All test titles use static, descriptive strings that clearly indicate what each test validates. Dynamic values appropriately belong in test bodies, not titles.
Test Structure And Quality ✅ Passed PR modifies only go.mod file without changing any test files, so there is no test code to review against quality criteria.
Title check ✅ Passed The title accurately describes the main change: updating a dependency digest for github.com/openshift/assisted-service/api to a new commit hash.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2026
@openshift-ci openshift-ci bot requested review from avishayt and danmanor February 25, 2026 00:27
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 25, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from ba6d7b1 to 0231153 Compare February 25, 2026 12:26
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to f90427b NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7ca2b35 Feb 25, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 0231153 to aa60395 Compare February 26, 2026 00:21
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7ca2b35 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 14d3eb3 Feb 26, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Around line 140-141: The go.mod bump shows
github.com/openshift/assisted-service/api at commit 14d3eb372bda while
github.com/openshift/assisted-service/models remains at an older commit
10cee3a746b9; because api imports and uses models types (HostRole, HostStage,
SourceState, ImageType) either (a) verify that the newer api commit is backward
compatible with the older models commit by checking those type definitions
across the two commits and confirming no breaking changes, or (b) update the
models replacement to the matching commit for 14d3eb372bda so both api and
models come from the same commit; locate references to the dependency entries in
go.mod and the usages of HostRole/HostStage/SourceState/ImageType to validate or
adjust versions accordingly.

ℹ️ Review info

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0231153 and aa60395.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (1)
  • go.mod

go.mod Outdated
Comment on lines 140 to 141
github.com/openshift/assisted-service/api => github.com/openshift/assisted-service/api v0.0.0-20260225184737-14d3eb372bda
github.com/openshift/assisted-service/models => github.com/openshift/assisted-service/models v0.0.0-20260223145238-10cee3a746b9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for imports of assisted-service api and models packages in codebase

echo "=== Searching for imports of assisted-service api and models packages ==="
rg -n --type=go 'github\.com/openshift/assisted-service/(api|models)' -g '!go.mod' -g '!go.sum' | head -50

echo -e "\n=== Files that import BOTH api and models packages ==="
api_files=$(rg -l --type=go 'github\.com/openshift/assisted-service/api' -g '!go.mod' -g '!go.sum' 2>/dev/null)
if [ -n "$api_files" ]; then
  echo "$api_files" | xargs -I {} sh -c 'if grep -q "github.com/openshift/assisted-service/models" {} 2>/dev/null; then echo "{}"; fi'
else
  echo "No Go files found importing assisted-service/api"
fi

echo -e "\n=== Checking go.mod for replace directive details ==="
grep -n -A1 -B1 'github.com/openshift/assisted-service' go.mod

Repository: openshift/cluster-api-provider-agent

Length of output: 3862


🏁 Script executed:

#!/bin/bash
# Examine the api types that import models to understand the dependency

echo "=== Checking infraenv_types.go for models usage ==="
head -30 vendor/github.com/openshift/assisted-service/api/v1beta1/infraenv_types.go | grep -E '^import|models'

echo -e "\n=== Checking agent_types.go for models usage ==="
head -30 vendor/github.com/openshift/assisted-service/api/v1beta1/agent_types.go | grep -E '^import|models'

echo -e "\n=== Checking what models types are used in agent_types.go ==="
grep -n 'models\.' vendor/github.com/openshift/assisted-service/api/v1beta1/agent_types.go | head -20

echo -e "\n=== Checking what models types are used in infraenv_types.go ==="
grep -n 'models\.' vendor/github.com/openshift/assisted-service/api/v1beta1/infraenv_types.go | head -20

Repository: openshift/cluster-api-provider-agent

Length of output: 918


🏁 Script executed:

#!/bin/bash
# Check go.sum for assisted-service package entries

echo "=== Checking go.sum for assisted-service entries ==="
grep 'github.com/openshift/assisted-service' go.sum | head -20

Repository: openshift/cluster-api-provider-agent

Length of output: 652


Verify version compatibility between api and models packages.

The api package has been updated to commit 14d3eb372bda (Feb 25), while the models package remains at commit 10cee3a746b9 (Feb 23). This is problematic because the api package directly imports and uses types from models (HostRole, HostStage, SourceState, ImageType). With a 2-day gap between versions from the same repository and direct type dependencies, confirm that the newer api is backward compatible with the older models version, or update models to the corresponding commit.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 140 - 141, The go.mod bump shows
github.com/openshift/assisted-service/api at commit 14d3eb372bda while
github.com/openshift/assisted-service/models remains at an older commit
10cee3a746b9; because api imports and uses models types (HostRole, HostStage,
SourceState, ImageType) either (a) verify that the newer api commit is backward
compatible with the older models commit by checking those type definitions
across the two commits and confirming no breaking changes, or (b) update the
models replacement to the matching commit for 14d3eb372bda so both api and
models come from the same commit; locate references to the dependency entries in
go.mod and the usages of HostRole/HostStage/SourceState/ImageType to validate or
adjust versions accordingly.

@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from aa60395 to 8f7fa18 Compare February 26, 2026 16:26
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 14d3eb3 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 31527fa Feb 26, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 8f7fa18 to 929ad93 Compare February 28, 2026 08:13
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 31527fa NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 5448b58 Feb 28, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 929ad93 to e334a30 Compare March 4, 2026 12:23
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 5448b58 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 628d368 Mar 4, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from e334a30 to 7a17991 Compare March 5, 2026 20:25
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 628d368 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7ceb3bf Mar 5, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 7a17991 to a3d5965 Compare March 6, 2026 04:23
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7ceb3bf NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 635ab20 Mar 6, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from a3d5965 to a87cd95 Compare March 6, 2026 08:12
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 635ab20 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 4cc92c8 Mar 6, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from a87cd95 to 35507e5 Compare March 6, 2026 20:26
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 4cc92c8 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 0291a8a Mar 6, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 35507e5 to 7b8369e Compare March 8, 2026 12:22
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 0291a8a NO-ISSUE: Update github.com/openshift/assisted-service/api digest to ca6968f Mar 8, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 7b8369e to 3af31a7 Compare March 8, 2026 16:15
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to ca6968f NO-ISSUE: Update github.com/openshift/assisted-service/api digest to f5efa52 Mar 8, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 3af31a7 to 60b4826 Compare March 9, 2026 17:06
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to f5efa52 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 988a064 Mar 9, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 60b4826 to 9dbaa80 Compare March 11, 2026 04:15
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 988a064 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 9ee4522 Mar 11, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 9dbaa80 to c978380 Compare March 11, 2026 18:29
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 9ee4522 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to f1cf688 Mar 11, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from c978380 to 11a1556 Compare March 11, 2026 21:33
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to f1cf688 NO-ISSUE: Update github.com/openshift/assisted-service/api digest to a7bea7e Mar 11, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 11a1556 to 3897e6d Compare March 12, 2026 16:28
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to a7bea7e NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 89897ad Mar 12, 2026
…7b05e33

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-api-digest branch from 3897e6d to cea53f5 Compare March 13, 2026 20:15
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 89897ad NO-ISSUE: Update github.com/openshift/assisted-service/api digest to 7b05e33 Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant