Skip to content

Red Hat Konflux update cluster-api-provider-agent-mce-50#849

Open
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux-cluster-api-provider-agent-mce-50
Open

Red Hat Konflux update cluster-api-provider-agent-mce-50#849
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux-cluster-api-provider-agent-mce-50

Conversation

@red-hat-konflux
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Please follow the block sequence indentation style introduced by the proprosed PipelineRuns YAMLs, or keep using consistent indentation level through your customized PipelineRuns. When different levels are mixed, it will be changed to the proposed style.

Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Walkthrough

Two new Tekton PipelineRun manifests are introduced for multi-platform container image builds: one for pull request validation and another for push/merge operations. Each pipeline orchestrates a multi-step workflow including repository cloning, dependency management, multi-arch image building, security scanning, and artifact management.

Changes

Cohort / File(s) Summary
Tekton Pipeline Configuration
.tekton/cluster-api-provider-agent-mce-50-pull-request.yaml, .tekton/cluster-api-provider-agent-mce-50-push.yaml
New Tekton PipelineRun manifests defining multi-platform container image build pipelines with comprehensive task orchestration, including repository cloning, dependency prefetching, multi-arch builds via buildah, security checks (clair-scan, sast, clamav, snyk, coverity), source image builds, artifact management, and Dockerfile updates. Pull-request variant includes quality gates; push variant includes RPM signature scanning.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch konflux-cluster-api-provider-agent-mce-50
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2026
@openshift-ci openshift-ci bot requested review from adriengentil and eranco74 March 13, 2026 20:18
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign adriengentil for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 13, 2026

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.tekton/cluster-api-provider-agent-mce-50-push.yaml (1)

91-94: Missing type field for enable-cache-proxy parameter.

The enable-cache-proxy parameter is missing the type: string field, which is present on all other string parameters in the pipelineSpec. For consistency and explicitness, consider adding it.

♻️ Suggested fix
     - default: "false"
       description: Enable cache proxy configuration
       name: enable-cache-proxy
+      type: string
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.tekton/cluster-api-provider-agent-mce-50-push.yaml around lines 91 - 94,
The pipeline parameter "enable-cache-proxy" in the pipelineSpec is missing an
explicit type; update the parameter definition for enable-cache-proxy to include
type: string (matching other string params) so the parameter block contains
name: enable-cache-proxy, description, default: "false" and type: string to keep
consistency and explicit typing.
.tekton/cluster-api-provider-agent-mce-50-pull-request.yaml (1)

94-96: Missing type field for enable-cache-proxy parameter.

Same issue as in the push pipeline - the enable-cache-proxy parameter is missing the type: string field for consistency with other parameters.

♻️ Suggested fix
     - default: "false"
       description: Enable cache proxy configuration
       name: enable-cache-proxy
+      type: string
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.tekton/cluster-api-provider-agent-mce-50-pull-request.yaml around lines 94
- 96, The parameter definition for enable-cache-proxy is missing its type;
update the parameter block for enable-cache-proxy to include "type: string"
(keeping the default value "false" and existing description) so it matches the
other pipeline parameters and avoids type inconsistencies.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.tekton/cluster-api-provider-agent-mce-50-pull-request.yaml:
- Around line 94-96: The parameter definition for enable-cache-proxy is missing
its type; update the parameter block for enable-cache-proxy to include "type:
string" (keeping the default value "false" and existing description) so it
matches the other pipeline parameters and avoids type inconsistencies.

In @.tekton/cluster-api-provider-agent-mce-50-push.yaml:
- Around line 91-94: The pipeline parameter "enable-cache-proxy" in the
pipelineSpec is missing an explicit type; update the parameter definition for
enable-cache-proxy to include type: string (matching other string params) so the
parameter block contains name: enable-cache-proxy, description, default: "false"
and type: string to keep consistency and explicit typing.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 68cb4e4b-7a7e-4c7e-9188-4c965d8da871

📥 Commits

Reviewing files that changed from the base of the PR and between 35a3cb8 and de691c7.

📒 Files selected for processing (2)
  • .tekton/cluster-api-provider-agent-mce-50-pull-request.yaml
  • .tekton/cluster-api-provider-agent-mce-50-push.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants