[release-4.22] OCPBUGS-92656: e2e/ccm-aws-ote: support to dual-stack IPv6 primary#480
Conversation
…st skips to 4.22 OTE Port dual-stack support changes from PR openshift#466 (main/5.0 branch) to the release-4.22 OTE structure under cmd/cloud-controller-manager-aws-tests-ext/: - Add GetCloudConfig and IsDualStack helpers to e2e/helper.go for detecting dual-stack clusters from the cloud-config ConfigMap NodeIPFamilies key. - In createServiceNLB (e2e/loadbalancer.go), set IPFamilyPolicy to RequireDualStack when the cluster is configured for dual-stack, ensuring NLB services work in dualstack IPv6-primary environments. - In main.go, detect dual-stack before building specs and exclude upstream loadbalancer tests ([cloud-provider-aws-e2e] loadbalancer) when the cluster is dual-stack with primary IPv6, since upstream tests do not support dual-stack yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-92656, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retitle [release-4.22] OCPBUGS-92656: e2e/ccm-aws-ote: support to dual-stack IPv6 primary |
|
/jira refresh |
|
@tthvo: This pull request references Jira Issue OCPBUGS-92656, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-installer-dualstack-ipv4-primary-techpreview |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview |
|
@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b21259f0-70d8-11f1-9c11-0f826c26e1cd-0 |
|
@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b22322d0-70d8-11f1-9362-7796f69c0964-0 |
|
/assign |
CI Test Analysis —
|
| Test | Result |
|---|---|
[cloud-provider-aws-e2e] nodes should label nodes with topology network info if instance is supported |
✅ Passed |
[cloud-provider-aws-e2e] nodes should set zone-id topology label |
✅ Passed |
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... should create NLB service with security group attached |
✅ Passed |
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... should cleanup security groups when service is deleted |
✅ Passed |
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... should have correct security group rules for service ports |
✅ Passed |
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... should have NLBSecurityGroupMode with 'Managed' value in cloud-config |
✅ Passed |
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... should have security groups attached to default ingress controller NLB |
✅ Passed |
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... should update security group rules when service is updated |
✅ Passed |
Upstream loadbalancer tests were correctly excluded in the dualstack IPv6-primary environment (CLB/NLB default, target-node-labels, hairpinning) — this validates the skip logic from this backport.
Job overall status: failure — but the failures are unrelated to the CCCMO backport:
[sig-network][Feature:EgressFirewall]— egress firewall test (sig-network)[sig-network][OCPFeatureGate:DNSNameResolver][Feature:EgressFirewall]— wildcard DNS egress firewall (sig-network)[sig-apps] poddisruptionbudgets ... AlwaysAllow/IfHealthyBudget— PDB tests (sig-apps)[Feature:NetworkSegmentation] ... UDN service— (informing/non-blocking)
📋 Regular e2e-aws-ovn Presubmit (results)
All 13 [cloud-provider-aws-e2e tests accounted for — 12 passed, 1 correctly skipped:
- ✅
[cloud-provider-aws-e2e] loadbalancer NLB should be reachable with default configurations— Passed - ✅
[cloud-provider-aws-e2e] loadbalancer NLB should be reachable with target-node-labels— Passed - ✅
[cloud-provider-aws-e2e] loadbalancer NLB internal should be reachable with hairpinning traffic— Passed - ✅
[cloud-provider-aws-e2e] loadbalancer CLB should be reachable with default configurations— Passed - ✅
[cloud-provider-aws-e2e] loadbalancer CLB internal should be reachable with hairpinning traffic— Passed - ✅
[cloud-provider-aws-e2e] nodes should label nodes with topology network info— Passed - ✅
[cloud-provider-aws-e2e] nodes should set zone-id topology label— Passed - ✅ 5x
[cloud-provider-aws-e2e-openshift] loadbalancer NLB ... security grouptests — Passed - ⏭️
[cloud-provider-aws-e2e-openshift] ... should have security groups attached to default ingress controller NLB— Skipped (default ingress uses CLB, not NLB — expected)
✅ Conclusion
The backport is functioning as designed:
- Dualstack IPv6-primary: Upstream
[cloud-provider-aws-e2e] loadbalancerspecs are correctly excluded; all openshift-specific downstream tests pass withIPFamilyPolicy: RequireDualStack. - Regular e2e-aws-ovn: All upstream and downstream loadbalancer tests run and pass (no regression).
- All job failures in the dualstack run are unrelated to this PR (
sig-networkegress firewall,sig-appsPDB tests).
Analysis generated by Chai Bot from this Slack thread.
Addendum: Dualstack IPv4-Primary Payload Job Results📋 Dualstack IPv4-Primary (results)All 13
Key observation: Unlike the IPv6-primary job (where upstream LB tests were correctly excluded), the IPv4-primary job ran all upstream loadbalancer tests and they all passed. This is the expected behavior — the skip logic only activates for dualstack IPv6-primary environments. Job overall status: failure — but the failures are identical to the IPv6-primary job and unrelated to the CCCMO backport:
✅ Updated Cross-Job Summary
The backport is validated across all three environments. No regressions detected. Analysis generated by Chai Bot from this Slack thread. |
|
@tthvo: This PR was included in a payload test run from openshift/origin#31337
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c57fbe80-7103-11f1-98bb-8108ddbaad73-0 |
|
@tthvo: This PR was included in a payload test run from openshift/origin#31337
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d832e250-7103-11f1-912f-104aeb182365-0 |
|
/lgtm |
|
/label backport-risk-assessed |
|
@sadasu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sadasu: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Still checking other jobs impacted by this change, plan to finish EOD. /hold
Nolan/Dam, would you mind applying the label |
|
/verified by CI by CCM-AWS OTE-provided tests (prefix Dual-stack jobs:
Regular AWS jobs must run tests regularly:
/lgtm |
|
@mtulio: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
|
OWNERs file for OTE is not updated in 4.22 branch. Asking in cloud team's channel for approvals. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtulio, nrb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f622188
into
openshift:release-4.22
|
@redhat-chai-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-92656 Jira Issue OCPBUGS-92656 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
Backport of PR #466 to release-4.22 — adds dual-stack IPFamilyPolicy support and upstream test skips to the OTE (OpenShift Tests Extension) for AWS CCM.
Changes
Ported to the 4.22 OTE structure under
cmd/cloud-controller-manager-aws-tests-ext/:GetCloudConfig(),isConfigPresentCloudConfig(), andIsDualStack()helpers for dual-stack detection via cloud-config ConfigMapcreateServiceNLB(), reads cloud-config and setsIPFamilyPolicy: RequireDualStackwhen the cluster is dual-stack[cloud-provider-aws-e2e] loadbalancerupstream specsTesting
Local:
go build,go test,go vet,gofmtall pass.CI:
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreviewFixes: https://redhat.atlassian.net/browse/OCPBUGS-92656
Backport of: #466