OCPBUGS-38079: Bump controller-runtime to v0.18.4#1122
Conversation
openshift-ci-robot
added
jira/severity-important
|
@Miciah: This pull request references Jira Issue OCPBUGS-38079, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I believe there's a missing @ in the description; what worked for me and yields no diffs to your go mod edit -replace=k8s.io/client-go=k8s.io/client-go@v0.30.2/lgtm |
Miciah
force-pushed
the
OCPBUGS-23742-bump-controller-runtime-to-v0.18.4
branch
from
63f3f9c to
202d887
Compare
|
@Miciah: This pull request references Jira Issue OCPBUGS-38079, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Thanks! You're right; I think I typed the wrong command, then corrected it, but pasted the wrong one in the commit message and PR description. Fixed in https://github.com/openshift/cluster-ingress-operator/compare/63f3f9cf1ea0720b9a63f2085f063b3a60f963eb..202d8870a2af3ea2a621695757b642bbf0f826b6. |
|
/lgtm |
openshift-merge-robot
added
the
needs-rebase
Bump the vendored sigs.k8s.io/controller-runtime package to v0.18.4, the
latest release, which uses the k8s.io/* v0.30.1 packages.
Bump the vendored k8s.io/client-go package to v0.30.2. A previous commit
bumped the other k8s.io/* packages to v0.30.2 but left k8s.io/client-go at
v0.29.0. However, controller-runtime v0.18.4 requires k8s.io/client-go
v0.30.0 or newer because of a breaking change in the client-go
leaderelection package.
go get sigs.k8s.io/controller-runtime@v0.18.4
go mod edit -replace=k8s.io/client-go=k8s.io/client-go@v0.30.2
go mod tidy
go mod vendor
Update calls to controller.Watch to adapt to breaking changes in
controller-runtime. Namely, the handler and predicate arguments have been
removed from Watch and are now specified as options on the source.
Additionally, the source.Kind type now has a type parameter, so it is
necessary to specify a client.Object type argument.
Follow-up to commit fdb6215, which bumped
the other k8s.io/* packages to v0.30.2.
This commit fixes OCPBUGS-38079.
https://issues.redhat.com/browse/OCPBUGS-38079
* go.mod: Bump.
* go.sum: Regenerate.
* pkg/operator/controller/canary/controller.go (New):
* pkg/operator/controller/certificate-publisher/controller.go (New):
* pkg/operator/controller/certificate/controller.go (New):
* pkg/operator/controller/clientca-configmap/controller.go (New):
* pkg/operator/controller/configurable-route/controller.go (New):
* pkg/operator/controller/crl/controller.go (New):
* pkg/operator/controller/dns/controller.go (New):
* pkg/operator/controller/gateway-service-dns/controller.go (NewUnmanaged):
* pkg/operator/controller/gatewayapi/controller.go (New):
* pkg/operator/controller/gatewayapi/controller_test.go
((fakeController).Watch):
* pkg/operator/controller/gatewayclass/controller.go (NewUnmanaged):
* pkg/operator/controller/ingress/controller.go (New):
* pkg/operator/controller/ingressclass/controller.go (New):
* pkg/operator/controller/monitoring-dashboard/controller.go (New):
* pkg/operator/controller/route-metrics/controller.go (New):
* pkg/operator/controller/status/controller.go (New):
* pkg/operator/controller/sync-http-error-code-configmap/controller.go
(New): Update for the new controller.Watch and source.Kind type signatures.
* vendor/*: Regenerate.
Miciah
force-pushed
the
OCPBUGS-23742-bump-controller-runtime-to-v0.18.4
branch
from
202d887 to
2639954
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
/label qe-approved |
openshift-ci
Bot
added
the
qe-approved
|
@Miciah: This pull request references Jira Issue OCPBUGS-38079, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
/test-required |
|
/retest-required |
|
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Miciah: Jira Issue OCPBUGS-38079: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-38079 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-ingress-operator |
7 participants
Bump the vendored sigs.k8s.io/controller-runtime package to v0.18.4, the latest release, which uses the k8s.io/* v0.30.1 packages.
Bump the vendored k8s.io/client-go package to v0.30.2. A previous commit bumped the other k8s.io/* packages to v0.30.2 but left k8s.io/client-go at v0.29.0. However, controller-runtime v0.18.4 requires k8s.io/client-go v0.30.0 or newer because of a breaking change in the client-go leaderelection package.
Update calls to
controller.Watchto adapt to breaking changes in controller-runtime. Namely, the handler and predicate arguments have been removed fromWatchand are now specified as options on the source. Additionally, thesource.Kindtype now has a type parameter, so it is necessary to specify aclient.Objecttype argument.Follow-up to #1046, which bumped the other k8s.io/* packages to v0.30.2.