Skip to content

cloudprovider: add vsphere provider #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Mar 28, 2019
Merged

cloudprovider: add vsphere provider #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/operator/configobservation/cloudprovider/observe_cloudprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ func ObserveCloudProviderNames(genericListers configobserver.Listers, recorder e
return previouslyObservedConfig, errs
case configv1.AWSPlatform:
cloudProvider = "aws"
case configv1.VSpherePlatform:
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue linking all vsphere related PRs into a single place? Just for reference. Otherwise, looks good.

Copy link
Copy Markdown
Member

@ingvagabund ingvagabund Mar 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vsphere intra platform got introduced by openshift/api#182. Though, it's quite generic PR.

cloudProvider = "vsphere"
case configv1.LibvirtPlatform:
case configv1.OpenStackPlatform:
// TODO(flaper87): Enable this once we've figured out a way to write the cloud provider config in the master nodes
Expand Down