Skip to content

Conversation

@hongkailiu
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 26, 2026
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Walkthrough

A new serial test case was added to the cluster-version-operator suite by inserting a matching test entry in the payload manifest and a corresponding test implementation in the test source file; the new entry mirrors the structure of existing tests.

Changes

Cohort / File(s) Summary
Serial test addition — manifest & test
.openshift-tests-extension/openshift_payload_cluster-version-operator.json, test/cvo/cvo.go
Added a new serial test named "cluster-version-operator-tests should support passing serial tests [Serial]" — new test object in the payload manifest and a matching g.It test in test/cvo/cvo.go, structure mirrors existing entries (labels, source, lifecycle, environmentSelector, resources).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@hongkailiu
Copy link
Member Author

Although the job failed, it showed what I need: the new job is not included in the test.

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1306/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn/2015998065680322560/artifacts/e2e-agnostic-ovn/openshift-e2e-test/artifacts/e2e.log | grep 'should support passing'
started: 1/279/428 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing tests"
passed: (0s) 2026-01-27T06:01:10 "[Jira:\"Cluster Version Operator\"] cluster-version-operator-tests should support passing tests"

That means the "Qualifiers" work.

Qualifiers: []string{
`!(name.contains("[Serial]") || name.contains("[Slow]"))`,

I will see if this job is included in the job to be added by this.

@hongkailiu
Copy link
Member Author

/retest-required
/verified by @hongkailiu

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 27, 2026
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

/retest-required
/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@DavidHurta DavidHurta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Holding in case we decide to run the openshift/conformance/serial test suite and not the openshift/cluster-version-operator/conformance/serial test suite (referencing https://github.com/openshift/release/pull/73934/changes#r2732559124).

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [DavidHurta,hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants