OTA-1833: Add a unit test to guide troubleshooting

[hongkailiu]

The failures in CI caused by a new feature set in o/api are not easy to troubleshoot. This pull adds a unit test it gives hint of what to check and a potential fix.

Hopefully this will reduce the time to troubleshoot the case. I believe it will pay off the time we spend on maintaining the set cvoSkipFeatureSets. Recently I have seen a similar thing in o/oc [1].

[1]. https://github.com/openshift/oc/blob/12e2f59e4bac8586da8ab10bfb243862ff0444f5/pkg/helpers/describe/describer_test.go#L112

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hongkailiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

The pull request refactors feature-set filtering logic in the payload rendering module by consolidating hardcoded filename checks into a reusable helper function (skipFeatureSets()), updating the renderDir() function signature with additional filter parameters, and adding test coverage to validate known feature sets.

Changes

Cohort / File(s)	Summary
Feature-set filtering refactoring pkg/payload/render.go	Introduces cvoSkipFeatureSets global set and skipFeatureSets() helper to centralize feature-set name checks (CustomNoUpgrade, TechPreviewNoUpgrade, DevPreviewNoUpgrade, OKD); updates renderDir() signature to accept additional parameters (skipFiles, filterGroupKind); removes inline substring checks in favor of helper-based filtering.
Test coverage additions pkg/payload/render_test.go	Adds configv1 and sets imports; introduces Test_cvoKnownFeatureSets() test that validates consistency between cvoSkipFeatureSets, configv1.Default, and AllFixedFeatureSets, with external PR references in failure messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@hongkailiu: This pull request references OTA-1833 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

The failures in CI caused by a new feature set in o/api are not easy to troubleshoot. This pull adds a unit test it gives hint of what to check and a potential fix.

Hopefully this will reduce the time to troubleshoot the case. I believe it will pay off the time we spend on maintaining the set cvoSkipFeatureSets. Recently I have seen a similar thing in o/oc [1].

[1]. https://github.com/openshift/oc/blob/12e2f59e4bac8586da8ab10bfb243862ff0444f5/pkg/helpers/describe/describer_test.go#L112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[hongkailiu]

/retest-required

[openshift-ci]

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-operator	2cc5021	link	true	/test e2e-agnostic-operator
ci/prow/e2e-agnostic-ovn	2cc5021	link	true	/test e2e-agnostic-ovn
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change	2cc5021	link	true	/test e2e-agnostic-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-techpreview	2cc5021	link	true	/test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.