Skip to content

[release-4.22] OCPBUGS-92829: Clean up old temp directories in downloads pod #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.22
Choose a base branch
from
Open

[release-4.22] OCPBUGS-92829: Clean up old temp directories in downloads pod #1177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions bindata/assets/deployments/downloads-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ spec:
- '-c'
- |
cat <<EOF >/tmp/serve.py
import errno, http.server, os, re, signal, socket, sys, tarfile, tempfile, threading, time, zipfile
import errno, http.server, os, re, shutil, signal, socket, sys, tarfile, tempfile, threading, time, zipfile

def shutdown_handler(signum, frame):
print("Received signal {}, shutting down...".format(signum), flush=True)
Expand Down Expand Up @@ -124,7 +124,22 @@ spec:
httpd.serve_forever()

print('Starting downloads server...', flush=True)
temp_dir = tempfile.mkdtemp()

# Clean up any existing download-* directories
TEMP_DIR_PREFIX = 'download-'
tmp_base = tempfile.gettempdir()
print('Cleaning up old temp directories in {}...'.format(tmp_base), flush=True)
for item in os.listdir(tmp_base):
if item.startswith(TEMP_DIR_PREFIX):
old_dir = os.path.join(tmp_base, item)
try:
if os.path.isdir(old_dir):
print(' Removing old directory: {}'.format(old_dir), flush=True)
shutil.rmtree(old_dir)
except Exception as e:
print(' WARNING: Failed to remove {}: {}'.format(old_dir, str(e)), flush=True)

temp_dir = tempfile.mkdtemp(prefix=TEMP_DIR_PREFIX)
print('Serving from: {}'.format(temp_dir), flush=True)
os.chdir(temp_dir)

Expand Down