-
Notifications
You must be signed in to change notification settings - Fork 667
OCPBUGS-72260: '0 of pods' are shown in Status column on DaemonSets list page. #15928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis change modifies the workload table component to correctly handle replica count display for DaemonSet resources. Previously, the component used uniform property access patterns for all workload types. The update introduces conditional logic that distinguishes between DaemonSets and other workload kinds, using 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
|
@cajieh: This pull request references Jira Issue OCPBUGS-72260, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rhamilto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
|
||
| // DaemonSets use different status fields than Deployments | ||
| const isDaemonSet = kind?.includes('DaemonSet'); | ||
| const statusReplicas = kind?.includes('DaemonSet') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
| const statusReplicas = kind?.includes('DaemonSet') | |
| const statusReplicas = isDaemonSet |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Before:
After:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.