Skip to content

CONSOLE-5042: Remove React.FCC #15929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
logonoff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CONSOLE-5042: Remove React.FCC #15929

logonoff wants to merge 2 commits into from
+562 −541

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Jan 20, 2026

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-5042 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and kyoto January 20, 2026 03:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared component/topology Related to topology labels Jan 20, 2026
@logonoff
Copy link
Member Author

logonoff commented Jan 20, 2026

/label px-approved
/label docs-approved

type-only changes, no runtime changes
/verified bypass

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 20, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2026

@logonoff: The verified label has been added.

Details

In response to this:

/label px-approved
/label docs-approved

type-only changes, no runtime changes
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 20, 2026
jhadvig
jhadvig reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @logonoff 🙌
Two small comments otherwise good to go 👍

frontend/packages/console-app/src/components/nodes/NodeLogs.tsx
};

const HeaderBanner: React.FCC<{ lineCount: number }> = ({ lineCount }) => {
const HeaderBanner: React.FC<{ lineCount: number }> = ({ lineCount }) => {
Copy link
Member

@jhadvig jhadvig Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const HeaderBanner: React.FC<{ lineCount: number }> = ({ lineCount }) => {
const HeaderBanner: FC<{ lineCount: number }> = ({ lineCount }) => {

frontend/public/components/namespace.jsx
};

/** @type {React.FCC<{namespace: K8sResourceKind}>} */
/** @type {React.FC<{namespace: K8sResourceKind}>} */
Copy link
Member

@jhadvig jhadvig Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know its a comment but lets stay consistent

Suggested change
/** @type {React.FC<{namespace: K8sResourceKind}>} */
/** @type {FC<{namespace: K8sResourceKind}>} */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig left review comments

@cajieh cajieh Awaiting requested review from cajieh

@kyoto kyoto Awaiting requested review from kyoto

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/knative Related to knative-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/olm Related to OLM component/shared Related to console-shared component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@logonoff @openshift-ci-robot @jhadvig