Skip to content

NO-JIRA: Downloads: Ensure cleanup of the artifact folder on each startup #16681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongkailiu wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Open

NO-JIRA: Downloads: Ensure cleanup of the artifact folder on each startup #16681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2a248c
Downloads: Ensure cleanup of the artifact folder on each startup
hongkailiu Jun 25, 2026
a95b53c
Handle an error properly
hongkailiu Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cmd/downloads/config/downloads_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,14 +313,18 @@ func TestNewDownloadsServerConfig_CleansOldRandomTempDirs(t *testing.T) {
})

oldDirs := []string{
defaultArtifactsDir,
"/tmp/artifacts1234test",
"/tmp/artifacts5678test",
}
leftover := "leftover"
for _, d := range oldDirs {
if err := os.MkdirAll(d, 0755); err != nil {
t.Fatalf("failed to create old temp dir %s: %v", d, err)
}
os.WriteFile(filepath.Join(d, "leftover"), []byte("data"), 0644)
if err := os.WriteFile(filepath.Join(d, leftover), []byte("data"), 0644); err != nil {
t.Fatalf("failed to write leftover file in %s: %v", d, err)
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

srcDir := t.TempDir()
Expand All @@ -335,6 +339,16 @@ func TestNewDownloadsServerConfig_CleansOldRandomTempDirs(t *testing.T) {
}

for _, d := range oldDirs {
if d == defaultArtifactsDir {
if _, err := os.Stat(d); err != nil {
t.Errorf("failed to stat artifacts dir: %v", err)
}
f := filepath.Join(d, leftover)
if _, err := os.Stat(f); !os.IsNotExist(err) {
t.Errorf("leftover %s should have been cleaned up, but still exists", f)
}
continue
}
if _, err := os.Stat(d); !os.IsNotExist(err) {
t.Errorf("old temp dir %s should have been cleaned up, but still exists", d)
}
Expand Down