Skip to content

Update OLMv0 lifecycle enhancement to use ExperimentalListPackageCustomSchemas gRPC endpoint#2013

Open
perdasilva wants to merge 1 commit into
openshift:masterfrom
perdasilva:update-to-list-package-custom-schemas
Open

Update OLMv0 lifecycle enhancement to use ExperimentalListPackageCustomSchemas gRPC endpoint#2013
perdasilva wants to merge 1 commit into
openshift:masterfrom
perdasilva:update-to-list-package-custom-schemas

Conversation

@perdasilva
Copy link
Copy Markdown

@perdasilva perdasilva commented May 18, 2026

Summary

  • Update all references from ListPackageCustomSchemas to ExperimentalListPackageCustomSchemas to match the actual operator-registry implementation
  • The endpoint lives on a new ExperimentalRegistry gRPC service, separate from the existing Registry service
  • Document the x-acknowledge-experimental: true gRPC metadata header requirement — without it, the endpoint silently returns an empty stream
  • Update input validation details to use the actual regex pattern (^[a-zA-Z0-9][a-zA-Z0-9._-]*$)
  • Correct pogreb storage format: blobs stored under a single metas/{schema}/{packageName} key as concatenated length-prefixed proto binary (not per-hash keys with prefix scan)
  • Update Console backend to include the experimental header in gRPC calls
  • Update test plan to cover missing experimental header behavior

Test plan

  • Enhancement document uses ExperimentalListPackageCustomSchemas consistently (no stale ListPackageCustomSchemas references)
  • API Extensions section accurately describes the ExperimentalRegistry service, header requirement, and validation
  • Implementation Details match the actual operator-registry code
  • Console Backend section includes experimental header in gRPC call description
  • Test plan covers experimental header behavior

🤖 Generated with Claude Code

@openshift-ci openshift-ci Bot requested review from jan--f and travier May 18, 2026 08:49
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stleerh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here


* As a cluster administrator, I want lifecycle and compatibility information to be available in disconnected environments, so that I have the same operational visibility regardless of cluster connectivity.

* As an operator author, I want to include lifecycle metadata in my operator's catalog entry, so that my users have visibility into the support status of my operator versions.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why don't we keep this? 🤔

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed to not cause confusion about who is adding the lifecycle metadata for this work. In our case, the lifecycle metadata is owned by another actor our of band of the operator authors (of course there's nothing stopping the operator author from doing so).

Comment thread enhancements/olm/lifecycle-and-compatibility.md Outdated
…ndpoint

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@perdasilva perdasilva force-pushed the update-to-list-package-custom-schemas branch from 7d6f4b1 to df436e3 Compare June 1, 2026 07:59
@perdasilva perdasilva changed the title Update OLMv0 lifecycle enhancement to use ListPackageCustomSchemas gRPC endpoint Update OLMv0 lifecycle enhancement to use ExperimentalListPackageCustomSchemas gRPC endpoint Jun 1, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2026

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants