Enhancement CNTRLPLANE-3527: Add Router to ServicePublishingStrategy for non-cloud platform support

[vsolanki12]

Why was this change needed?

The HCP private router Service is unconditionally created as LoadBalancer regardless of platform.
On management clusters without cloud load-balancer support (Agent, KubeVirt, None platforms), the
Service stays Pending indefinitely, blocking route status propagation and KAS service resolution.

OCPBUGS-77856 identified this issue. PR openshift/hypershift#8439 provided an initial fix using
platform auto-detection, but was closed after review identified that ClusterIP used for NodePort
services is not externally reachable.

What changes are being made?

This enhancement proposes adding Router as a new ServiceType in spec.services[], extending
the existing ServicePublishingStrategyMapping pattern to cover the private router. This gives
operators explicit control over the service type and external address used to reach HCP routes.

Key changes:

• New Router ServiceType constant in the HostedCluster API
• Reuses existing NodePortPublishingStrategy (address + port fields)
• CPO reads the strategy to determine service type and external address
• Backward compatible — no Router entry defaults to LoadBalancer

References

• Epic: https://issues.redhat.com/browse/CNTRLPLANE-3527
• Original bug: https://issues.redhat.com/browse/OCPBUGS-77856
• Initial fix PR (closed): OCPBUGS-77856: fix: use NodePort for HCP router Service on non-cloud platforms hypershift#8439

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@vsolanki12: This pull request references CNTRLPLANE-3527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Why was this change needed?

The HCP private router Service is unconditionally created as LoadBalancer regardless of platform.
On management clusters without cloud load-balancer support (Agent, KubeVirt, None platforms), the
Service stays Pending indefinitely, blocking route status propagation and KAS service resolution.

OCPBUGS-77856 identified this issue. PR openshift/hypershift#8439 provided an initial fix using
platform auto-detection, but was closed after review identified that ClusterIP used for NodePort
services is not externally reachable.

What changes are being made?

This enhancement proposes adding Router as a new ServiceType in spec.services[], extending
the existing ServicePublishingStrategyMapping pattern to cover the private router. This gives
operators explicit control over the service type and external address used to reach HCP routes.

Key changes:

• New Router ServiceType constant in the HostedCluster API
• Reuses existing NodePortPublishingStrategy (address + port fields)
• CPO reads the strategy to determine service type and external address
• Backward compatible — no Router entry defaults to LoadBalancer

References

• Epic: https://issues.redhat.com/browse/CNTRLPLANE-3527
• Original bug: https://issues.redhat.com/browse/OCPBUGS-77856
• Initial fix PR (closed): OCPBUGS-77856: fix: use NodePort for HCP router Service on non-cloud platforms hypershift#8439

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• enhancements/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment