Skip to content

CONSOLE-5163: Enhancement for Ingress componentRoutes labels#2033

Open
Leo6Leo wants to merge 3 commits into
openshift:masterfrom
Leo6Leo:CONSOLE-5163
Open

CONSOLE-5163: Enhancement for Ingress componentRoutes labels#2033
Leo6Leo wants to merge 3 commits into
openshift:masterfrom
Leo6Leo:CONSOLE-5163

Conversation

@Leo6Leo
Copy link
Copy Markdown

@Leo6Leo Leo6Leo commented Jun 4, 2026

Summary

Add a labels field to ComponentRouteSpec in the Ingress config API (config.openshift.io/v1). This enables cluster administrators to specify labels on component-managed routes so that IngressControllers using route selectors can manage them for route sharding scenarios.

This enhancement covers the API change only. Operator-side consumption is tracked separately per operator.

API Change

  • New LabelValue validated string type in config/v1/types_ingress.go
  • New Labels map[string]LabelValue field on ComponentRouteSpec
  • Gated behind IngressComponentRouteLabels FeatureGate (TechPreviewNoUpgrade, DevPreviewNoUpgrade)
  • CEL validation: format.qualifiedName() for keys, format.labelValue() for values, reserved prefix rejection
  • MinProperties=1, MaxProperties=8, +mapType=granular

Related

Test plan

  • Template linter passes (hack/template-lint.sh)
  • Metadata linter passes (approvers/api-approvers TBD until reviewers assigned)
  • All claims verified against latest API PR source code

🤖 Generated with Claude Code

Leo6Leo added 3 commits May 28, 2026 14:18
Add enhancement proposal for a labels field on ComponentRouteSpec
in the Ingress config API. This enables cluster admins to specify
labels on component-managed routes for IngressController route
sharding scenarios.
- Add missing metadata (status, see-also)
- Fix Go type to map[string]LabelValue matching implementation
- Add required sections: Drawbacks, Alternatives, OKE topology, Open Questions
- Expand Workflow Description with actors, starting state, and failure cases
- Add Label Conflict and Removal Behavior section
- Expand Operational Aspects with failure modes, SLI impact, escalation
- Expand Support Procedures with diagnostic oc commands
- Remove false test plan claim (empty labels map test)
- Update last-updated date
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 4, 2026

@Leo6Leo: This pull request references CONSOLE-5163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add a labels field to ComponentRouteSpec in the Ingress config API (config.openshift.io/v1). This enables cluster administrators to specify labels on component-managed routes so that IngressControllers using route selectors can manage them for route sharding scenarios.

This enhancement covers the API change only. Operator-side consumption is tracked separately per operator.

API Change

  • New LabelValue validated string type in config/v1/types_ingress.go
  • New Labels map[string]LabelValue field on ComponentRouteSpec
  • Gated behind IngressComponentRouteLabels FeatureGate (TechPreviewNoUpgrade, DevPreviewNoUpgrade)
  • CEL validation: format.qualifiedName() for keys, format.labelValue() for values, reserved prefix rejection
  • MinProperties=1, MaxProperties=8, +mapType=granular

Related

Test plan

  • Template linter passes (hack/template-lint.sh)
  • Metadata linter passes (approvers/api-approvers TBD until reviewers assigned)
  • All claims verified against latest API PR source code

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from candita and knobunc June 4, 2026 21:18
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/markdownlint 615ab72 link true /test markdownlint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants