Skip to content

Adopt conmon-rs as default container monitor#2034

Open
saschagrunert wants to merge 1 commit into
openshift:masterfrom
saschagrunert:conmon-rs-enhancement
Open

Adopt conmon-rs as default container monitor#2034
saschagrunert wants to merge 1 commit into
openshift:masterfrom
saschagrunert:conmon-rs-enhancement

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert commented Jun 5, 2026

Propose switching CRI-O from the traditional per-container conmon to the pod-level conmon-rs monitor in OpenShift.

  • Introduce ConmonRS feature gate in TechPreviewNoUpgrade
  • Extend ContainerRuntimeConfig with a containerMonitor field (PascalCase enum: Conmon, ConmonRS)
  • Move conmon-rs package from RHCOS layer to the Node Layer (OCP-aligned versioning)
  • Graduate from Tech Preview (opt-in) to GA (default) over one minor release cycle
  • Tracking: OCPNODE-1288

/cc @haircommander @rphillips

@openshift-ci openshift-ci Bot requested review from haircommander and rphillips June 5, 2026 09:14
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rvanderp3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert force-pushed the conmon-rs-enhancement branch 9 times, most recently from 8c3987a to ca49d66 Compare June 5, 2026 09:54
@saschagrunert saschagrunert changed the title WIP: enhancement: adopt conmon-rs as default container monitor Adopt conmon-rs as default container monitor Jun 5, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@saschagrunert saschagrunert force-pushed the conmon-rs-enhancement branch from ca49d66 to 672b352 Compare June 5, 2026 09:59
@saschagrunert
Copy link
Copy Markdown
Member Author

@bitoku @harche @QiWang19 PTAL, too

Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md Outdated
Comment thread enhancements/machine-config/conmon-rs-default-container-monitor.md
@saschagrunert saschagrunert force-pushed the conmon-rs-enhancement branch from 672b352 to 5eda281 Compare June 5, 2026 11:48
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert force-pushed the conmon-rs-enhancement branch from 5eda281 to 0b18266 Compare June 5, 2026 11:56
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@saschagrunert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/markdownlint 0b18266 link true /test markdownlint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

2. **Feature Gate and API Extension**: Introduce a
`ConmonRS` feature gate in `TechPreviewNoUpgrade`
and extend the MCO's `ContainerRuntimeConfig` CR
with a `containerMonitor` field gated behind it.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I prefer embedding in default runtime. there could be a "crun-conmonrs" option. less api surface. I don't feel really stubborn about that though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants