Adopt conmon-rs as default container monitor#2034
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8c3987a to
ca49d66
Compare
ca49d66 to
672b352
Compare
672b352 to
5eda281
Compare
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
5eda281 to
0b18266
Compare
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| 2. **Feature Gate and API Extension**: Introduce a | ||
| `ConmonRS` feature gate in `TechPreviewNoUpgrade` | ||
| and extend the MCO's `ContainerRuntimeConfig` CR | ||
| with a `containerMonitor` field gated behind it. |
There was a problem hiding this comment.
personally I prefer embedding in default runtime. there could be a "crun-conmonrs" option. less api surface. I don't feel really stubborn about that though
Propose switching CRI-O from the traditional per-container conmon to the pod-level conmon-rs monitor in OpenShift.
ConmonRSfeature gate inTechPreviewNoUpgradeContainerRuntimeConfigwith acontainerMonitorfield (PascalCase enum:Conmon,ConmonRS)/cc @haircommander @rphillips