WIP: Add MSI Support for Azure HostedClusters by bryan-cox · Pull Request #4484 · openshift/hypershift

bryan-cox · 2024-08-05T13:59:50Z

What this PR does / why we need it:
This PR adds:

API support for the client IDs related to the MSIs for cluster-image-registry, cluster-ingress, cluster-storage,
and cluster-network operators
Adds an environment variable AZURE_MSI_AUTHENTICATION, set to true when the client ID is provided, in the deployments of cluster-image-registry, cluster-ingress, cluster-storage,
and cluster-network operators

Which issue(s) this PR fixes:
Fixes #

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci · 2024-08-05T14:00:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

netlify · 2024-08-05T14:01:01Z

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	`afb0388`
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/66b24047beba7a0008d51f53
😎 Deploy Preview	https://deploy-preview-4484--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci · 2024-08-05T14:01:40Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2024-08-05T14:10:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-08-06T15:15:49Z

@bryan-cox: This pull request references NE-1688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references SDN-4773 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references STOR-1992 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references IR-467 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

Details

In response to this:

What this PR does / why we need it:
This PR adds:

API support for the client IDs related to the MSIs for cluster-image-registry, cluster-ingress, cluster-storage,
and cluster-network operators

Adds an environment variable AZURE_MSI_AUTHENTICATION, set to true when the client ID is provided, in the deployments of cluster-image-registry, cluster-ingress, cluster-storage,
and cluster-network operators

Which issue(s) this PR fixes:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2024-08-06T16:30:02Z

/test all

Adds fields in the Azure HostedCluster API for the client IDs related to the managed service identities used for the following control plane components: cluster-image-registry, cluster-ingress, cluster-storage, and cluster-network operators Signed-off-by: Bryan Cox <brcox@redhat.com>

bryan-cox · 2024-08-06T22:52:34Z

/test all

Set the Azure MSI override for the cluster-image-registry-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

Set the Azure MSI override in the cluster-ingress-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

Set the Azure MSI override for the cluster-storage-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

Set the Azure MSI override for the cluster-network-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

bryan-cox · 2024-08-07T00:23:11Z

/test all

bryan-cox · 2024-08-07T09:10:32Z

/retest

bryan-cox · 2024-08-07T12:44:14Z

/test e2e-aws

muraee · 2024-08-07T13:38:02Z

+	//
+	// +kubebuilder:validation:Required
+	// +required
+	ImageRegistryMSIClientID string `json:"imageRegistryMSIClientID,omitempty"`


required fields should not have omitempty
same comment for the rest of the fields.

openshift-ci · 2024-08-07T15:28:25Z

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-kubevirt-aws-ovn-reduced	`e542a67`	link	true	`/test e2e-kubevirt-aws-ovn-reduced`
ci/prow/e2e-aks	`e542a67`	link	false	`/test e2e-aks`
ci/prow/e2e-azure	`e542a67`	link	false	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-08-08T19:11:06Z

@bryan-cox: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

What this PR does / why we need it:
This PR adds:

API support for the client IDs related to the MSIs for cluster-image-registry, cluster-ingress, cluster-storage,
and cluster-network operators

Adds an environment variable AZURE_MSI_AUTHENTICATION, set to true when the client ID is provided, in the deployments of cluster-image-registry, cluster-ingress, cluster-storage,
and cluster-network operators

Which issue(s) this PR fixes:
Fixes #

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2024-08-13T16:45:18Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bryan-cox · 2024-09-10T12:03:22Z

/close
Working on this through #4690

openshift-ci · 2024-09-10T12:03:33Z

@bryan-cox: Closed this PR.

Details

In response to this:

/close
Working on this through #4690

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 5, 2024

openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Aug 5, 2024

bryan-cox force-pushed the msi-deployment branch 6 times, most recently from f3eebcb to 5db947e Compare August 6, 2024 14:46

bryan-cox changed the title ~~WIP: Add ImageRegistry MSI to HostedCluster for Azure~~ Add MSI Support for Azure HostedClusters Aug 6, 2024

bryan-cox changed the title ~~Add MSI Support for Azure HostedClusters~~ NE-1688,SDN-4773,STOR-1992,IR-467:Add MSI Support for Azure HostedClusters Aug 6, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2024

bryan-cox changed the title ~~NE-1688,SDN-4773,STOR-1992,IR-467:Add MSI Support for Azure HostedClusters~~ NE-1688,SDN-4773,STOR-1992,IR-467: Add MSI Support for Azure HostedClusters Aug 6, 2024

bryan-cox force-pushed the msi-deployment branch 2 times, most recently from afb0388 to 7da38f4 Compare August 6, 2024 16:25

bryan-cox force-pushed the msi-deployment branch from 7da38f4 to 31e4784 Compare August 6, 2024 22:51

bryan-cox added 4 commits August 6, 2024 20:18

Set Azure MSI override for cluster-image-registry

de2ac6a

Set the Azure MSI override for the cluster-image-registry-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

Set Azure MSI override in cluster-ingress-operator

610fd23

Set the Azure MSI override in the cluster-ingress-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

Set Azure MSI override in cluster-storage-operator

3d32cdd

Set the Azure MSI override for the cluster-storage-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

Set Azure MSI override in cluster-network-operator

e542a67

Set the Azure MSI override for the cluster-network-operator deployment through an environment variable. Signed-off-by: Bryan Cox <brcox@redhat.com>

bryan-cox force-pushed the msi-deployment branch from 31e4784 to e542a67 Compare August 7, 2024 00:22

bryan-cox marked this pull request as ready for review August 7, 2024 12:47

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024

openshift-ci Bot requested review from enxebre and hasueki August 7, 2024 12:48

muraee reviewed Aug 7, 2024

View reviewed changes

bryan-cox marked this pull request as draft August 8, 2024 19:10

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024

bryan-cox changed the title ~~NE-1688,SDN-4773,STOR-1992,IR-467: Add MSI Support for Azure HostedClusters~~ WIP: Add MSI Support for Azure HostedClusters Aug 8, 2024

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024

openshift-ci Bot closed this Sep 10, 2024

Conversation

bryan-cox commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Aug 5, 2024

Uh oh!

netlify Bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for hypershift-docs ready!

Uh oh!

openshift-ci Bot commented Aug 5, 2024

Uh oh!

openshift-ci Bot commented Aug 5, 2024

Uh oh!

openshift-ci-robot commented Aug 6, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryan-cox commented Aug 6, 2024

Uh oh!

bryan-cox commented Aug 6, 2024

Uh oh!

bryan-cox commented Aug 7, 2024

Uh oh!

bryan-cox commented Aug 7, 2024

Uh oh!

bryan-cox commented Aug 7, 2024

Uh oh!

muraee Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 7, 2024

Uh oh!

openshift-ci-robot commented Aug 8, 2024

Uh oh!

openshift-merge-robot commented Aug 13, 2024

Uh oh!

bryan-cox commented Sep 10, 2024

Uh oh!

openshift-ci Bot commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bryan-cox commented Aug 5, 2024 •

edited

Loading

netlify Bot commented Aug 5, 2024 •

edited

Loading

openshift-ci-robot commented Aug 6, 2024 •

edited by openshift-ci Bot

Loading