[release-4.18] OCPBUGS-45347: Reconcile SecretProvider for CNCC on ARO HCP by bryan-cox · Pull Request #5224 · openshift/hypershift

bryan-cox · 2024-12-03T16:05:15Z

What this PR does / why we need it:
This PR is a manual cherrypick of:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45347

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Reconcile the SecretProviderClass for the cloud network config controller (CNCC) for ARO HCP deployments. The SecretProviderClass is used by the Secrets Store CSI driver to mount a certificate to a volume in the CNCC pod deployment. Signed-off-by: Bryan Cox <brcox@redhat.com>

Pass only the certificate name for the CNO deployment for managed Azure. CNO uses its own certificate path here, https://github.com/openshift/cluster-network-operator/blob/7736bfe37f1276f771fcef03077f6d840eb6b862/pkg/network/cloud_network.go#L23. This is combined with the certificate name here, https://github.com/openshift/cluster-network-operator/blob/7736bfe37f1276f771fcef03077f6d840eb6b862/pkg/network/cloud_network.go#L111.

openshift-ci-robot · 2024-12-03T16:05:21Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45347, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-44967 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
This PR is a manual cherrypick of:

OCPBUGS-44967: Reconcile SecretProvider for CNCC on ARO HCP #4903

OCPBUGS-44967: Pass only the certificate name for CNO deployment #5216

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45347

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-12-03T16:05:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jparrill · 2024-12-10T08:40:10Z

/retest

bryan-cox · 2024-12-11T15:58:31Z

/retest

bryan-cox · 2025-01-06T15:40:46Z

/jira refresh

openshift-ci-robot · 2025-01-06T15:40:51Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45347, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2025-01-06T15:42:14Z

/jira refresh

openshift-ci-robot · 2025-01-06T15:42:23Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45347, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-44967 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-44967 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2025-01-06T15:42:30Z

/retest

bryan-cox · 2025-01-06T15:50:43Z

/jira refresh

openshift-ci-robot · 2025-01-06T15:50:48Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45347, which is valid.

9 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-44967 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent bug Jira Issue OCPBUGS-44967 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-44967 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
dependent Jira Issue OCPBUGS-44967 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-01-06T18:46:00Z

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-aws	`4034757`	link	false	`/test e2e-openstack-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

enxebre · 2025-01-07T12:24:03Z

/lgtm

openshift-ci-robot · 2025-01-07T14:49:06Z

@bryan-cox: Jira Issue OCPBUGS-45347: All pull requests linked via external trackers have merged:

openshift/hypershift#5224

Jira Issue OCPBUGS-45347 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
This PR is a manual cherrypick of:

OCPBUGS-44967: Reconcile SecretProvider for CNCC on ARO HCP #4903

OCPBUGS-44967: Pass only the certificate name for CNO deployment #5216

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45347

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-07T19:08:03Z

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202501071837.p0.gd899191.assembly.stream.el9.
All builds following this will include this PR.

bryan-cox added 2 commits December 3, 2024 11:03

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 3, 2024

openshift-ci Bot added the do-not-merge/needs-area label Dec 3, 2024

openshift-ci Bot requested review from enxebre and hasueki December 3, 2024 16:05

openshift-ci Bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 3, 2024

openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Dec 3, 2024

bryan-cox changed the title ~~OCPBUGS-45347:~~ [release-4.18] OCPBUGS-45347: Reconcile SecretProvider for CNCC on ARO HCP Dec 3, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2025

openshift-ci Bot assigned enxebre Jan 7, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025

openshift-merge-bot Bot merged commit d899191 into openshift:release-4.18 Jan 7, 2025

bryan-cox deleted the OCPBUGS-45347 branch January 7, 2025 14:55

Conversation

bryan-cox commented Dec 3, 2024

Uh oh!

openshift-ci-robot commented Dec 3, 2024

Uh oh!

openshift-ci Bot commented Dec 3, 2024

Uh oh!

jparrill commented Dec 10, 2024

Uh oh!

bryan-cox commented Dec 11, 2024

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

openshift-ci-robot commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

openshift-ci-robot commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

openshift-ci-robot commented Jan 6, 2025

Uh oh!

openshift-ci Bot commented Jan 6, 2025

Uh oh!

enxebre commented Jan 7, 2025

Uh oh!

openshift-ci-robot commented Jan 7, 2025

Uh oh!

openshift-bot commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants