Skip to content

[release-4.18] OCPBUGS-45349: CPO fails to reconcile the SecretProviderClass for CSO on ARO HCP#5225

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.18from
bryan-cox:OCPBUGS-45349
Jan 9, 2025
Merged

[release-4.18] OCPBUGS-45349: CPO fails to reconcile the SecretProviderClass for CSO on ARO HCP#5225
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.18from
bryan-cox:OCPBUGS-45349

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented Dec 3, 2024

What this PR does / why we need it:
This is a manual cherrypick of:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45349

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 3, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 3, 2024

@bryan-cox: This pull request references Jira Issue OCPBUGS-45349, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
This is a manual cherrypick of:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45349

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 3, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Dec 3, 2024
@bryan-cox bryan-cox changed the title OCPBUGS-45349: CPO fails to reconcile the SecretProviderClass for CSO on ARO HCP [release-4.18] OCPBUGS-45349: CPO fails to reconcile the SecretProviderClass for CSO on ARO HCP Dec 3, 2024
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 11, 2024

/retest

1 similar comment
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Jan 6, 2025

/retest

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Jan 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 6, 2025

@bryan-cox: This pull request references Jira Issue OCPBUGS-45349, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-44968 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-44968 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Jan 6, 2025

/retest

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Jan 7, 2025

/test e2e-aks

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Jan 7, 2025

ci/prow/e2e-aks is failing because it needs #5348

@Patryk-Stefanski
Copy link
Copy Markdown
Contributor

Patryk-Stefanski commented Jan 8, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 8, 2025

/retest-required

Remaining retests: 0 against base HEAD c2d22ec and 2 for PR HEAD 7c50b7c in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@Patryk-Stefanski
Copy link
Copy Markdown
Contributor

Patryk-Stefanski commented Jan 8, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@bryan-cox
Reconcile SecretProvider for the CSO on ARO HCP
a0ebee1 
Reconcile the SecretProviderClass for the cluster storage operator (CSO)
 for ARO HCP deployments. The SecretProviderClass is used by the Secrets
Store CSI driver to mount a certificate to a volume in the
azure-disk-csi-controller and azure-file-csi-controller pod deployments.

Signed-off-by: Bryan Cox <brcox@redhat.com>
@bryan-cox
Reconcile Secret Data for Azure Disk and File CSI
d97de54 
Reconcile the secret data needed for the azure-disk and azure-file CSI
controllers. The format is the same as the Cloud Provider. More info on
the configuration can be found here:

https://cloud-provider-azure.sigs.k8s.io/install/configs/
Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 8, 2025

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Patryk-Stefanski
Copy link
Copy Markdown
Contributor

Patryk-Stefanski commented Jan 9, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 1388902 into openshift:release-4.18 Jan 9, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 9, 2025

@bryan-cox: Jira Issue OCPBUGS-45349: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45349 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
This is a manual cherrypick of:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45349

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox deleted the OCPBUGS-45349 branch January 9, 2025 12:02
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jan 9, 2025

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202501091344.p0.g1388902.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@Patryk-Stefanski Patryk-Stefanski

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bryan-cox @openshift-ci-robot @Patryk-Stefanski @openshift-bot