[release-4.18] OCPBUGS-45524: Implement Managed Identities in HyperShift by bryan-cox · Pull Request #5233 · openshift/hypershift

bryan-cox · 2024-12-04T18:00:43Z

What this PR does / why we need it:
Manual backport of

OCPBUGS-42434: Enable Managed Identity w/ Certificates in HyperShift Control Plane Components #5160

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45524

Checklist

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

openshift-ci-robot · 2024-12-04T18:00:50Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45524, which is invalid:

expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
Manual backport of

OCPBUGS-42434: Enable Managed Identity w/ Certificates in HyperShift Control Plane Components #5160

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45524

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-12-04T18:01:11Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45524, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

What this PR does / why we need it:
Manual backport of

OCPBUGS-42434: Enable Managed Identity w/ Certificates in HyperShift Control Plane Components #5160

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45524

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2024-12-10T08:41:35Z

/retest

bryan-cox · 2024-12-11T15:57:35Z

/retest

openshift-ci · 2024-12-11T16:59:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bryan-cox · 2025-01-06T15:44:01Z

/retest

bryan-cox · 2025-01-06T16:14:41Z

/jira refresh

openshift-ci-robot · 2025-01-06T16:14:48Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45524, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2025-01-06T16:15:16Z

/jira refresh

openshift-ci-robot · 2025-01-06T16:15:25Z

@bryan-cox: This pull request references Jira Issue OCPBUGS-45524, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.18.0) matches configured target version for branch (4.18.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-42434 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-42434 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bryan-cox · 2025-01-06T19:33:26Z

/retest-required

bryan-cox · 2025-01-07T12:00:25Z

/retest

enxebre · 2025-01-07T12:24:00Z

/lgtm

This commit authenticates Azure KMS with certificate authentication in order to communicate with Azure Cloud API. The certificate is stored in an Azure key vault and mounted into the KAS pod through a Secrets Store CSI driver SecretProviderClass. Signed-off-by: Bryan Cox <brcox@redhat.com>

Reconcile the SecretProviderClass for the control plane operator for ARO HCP deployments. The SecretProviderClass is used by the Secrets Store CSI driver to mount a certificate to a volume in the control plane operator pod deployment. Signed-off-by: Bryan Cox <brcox@redhat.com>

Update the go.mod to include the specific commit that includes the changes to allow service principal with certificate to use a certificate . Signed-off-by: Bryan Cox <brcox@redhat.com>

This commit authenticates CAPZ with certificate authentication in order to communicate with Azure Cloud API. The certificate is stored in an Azure key vault and mounted into the capi-provider pod through a Secrets Store CSI driver SecretProviderClass. Signed-off-by: Bryan Cox <brcox@redhat.com>

This commit changes the authentication from client secret to client certificate as well as reconciling the SecretProviderClass for cloud provider for ARO HCP deployments. The SecretProviderClass is used by the Secrets Store CSI driver to mount a certificate to a volume in the azure-cloud-controller-manager pod's deployment. Signed-off-by: Bryan Cox <brcox@redhat.com>

Update the RBAC for the HyperShift Operator (HO) to include 'update' for secrets-store.csi.x-k8s.io on managed Azure deployments of the HO. Signed-off-by: Bryan Cox <brcox@redhat.com>

enxebre · 2025-01-07T16:09:37Z

/hold
this needs to pass aks e2e test which seems missing here

enxebre · 2025-01-07T16:13:39Z

/test e2e-aks

bryan-cox · 2025-01-07T18:29:02Z

/retest

openshift-ci · 2025-01-07T20:28:09Z

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-4-18	`704912a`	link	true	`/test e2e-aws-4-18`
ci/prow/e2e-openstack-aws	`704912a`	link	false	`/test e2e-openstack-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bryan-cox · 2025-01-07T21:05:28Z

/retest-required

bryan-cox · 2025-01-08T13:38:47Z

/hold cancel

enxebre · 2025-01-08T13:52:37Z

/lgtm

openshift-ci-robot · 2025-01-08T16:06:11Z

@bryan-cox: Jira Issue OCPBUGS-45524: All pull requests linked via external trackers have merged:

openshift/hypershift#5233

Jira Issue OCPBUGS-45524 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
Manual backport of

OCPBUGS-42434: Enable Managed Identity w/ Certificates in HyperShift Control Plane Components #5160

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-45524

Checklist

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-08T18:46:30Z

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202501081809.p0.gc2d22ec.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 4, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 4, 2024

openshift-ci Bot added the do-not-merge/needs-area label Dec 4, 2024

bryan-cox changed the base branch from main to release-4.18 December 4, 2024 18:01

openshift-ci Bot requested review from csrwng and hasueki December 4, 2024 18:02

bryan-cox changed the title ~~[release-4.18 backport] OCPBUGS-45524: Implement Managed Identities in HyperShift~~ [release-4.18] OCPBUGS-45524: Implement Managed Identities in HyperShift Dec 4, 2024

bryan-cox force-pushed the OCPBUGS-45524 branch from 704912a to 8285fba Compare December 11, 2024 16:58

bryan-cox force-pushed the OCPBUGS-45524 branch from 8285fba to 8b86bce Compare January 6, 2025 16:12

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2025

openshift-ci Bot assigned enxebre Jan 7, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025

bryan-cox added 6 commits January 7, 2025 10:06

Update go.mod to include cert changes for CAPZ

98797d8

Update the go.mod to include the specific commit that includes the changes to allow service principal with certificate to use a certificate . Signed-off-by: Bryan Cox <brcox@redhat.com>

Update RBAC for HyperShift Operator

4f0a989

Update the RBAC for the HyperShift Operator (HO) to include 'update' for secrets-store.csi.x-k8s.io on managed Azure deployments of the HO. Signed-off-by: Bryan Cox <brcox@redhat.com>

bryan-cox force-pushed the OCPBUGS-45524 branch from 8b86bce to 4f0a989 Compare January 7, 2025 15:10

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025

openshift-merge-bot Bot merged commit c2d22ec into openshift:release-4.18 Jan 8, 2025

bryan-cox deleted the OCPBUGS-45524 branch January 8, 2025 16:12

Conversation

bryan-cox commented Dec 4, 2024

Uh oh!

openshift-ci-robot commented Dec 4, 2024

Uh oh!

openshift-ci-robot commented Dec 4, 2024

Uh oh!

jparrill commented Dec 10, 2024

Uh oh!

bryan-cox commented Dec 11, 2024

Uh oh!

openshift-ci Bot commented Dec 11, 2024

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

openshift-ci-robot commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

openshift-ci-robot commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 6, 2025

Uh oh!

bryan-cox commented Jan 7, 2025

Uh oh!

enxebre commented Jan 7, 2025

Uh oh!

enxebre commented Jan 7, 2025

Uh oh!

enxebre commented Jan 7, 2025

Uh oh!

bryan-cox commented Jan 7, 2025

Uh oh!

openshift-ci Bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bryan-cox commented Jan 7, 2025

Uh oh!

bryan-cox commented Jan 8, 2025

Uh oh!

enxebre commented Jan 8, 2025

Uh oh!

openshift-ci-robot commented Jan 8, 2025

Uh oh!

openshift-bot commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci Bot commented Jan 7, 2025 •

edited

Loading