Skip to content

CNTRLPLANE-3324: Enable gocyclo linter and reduce cyclomatic complexity #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 7 commits into from
May 11, 2026
Merged

CNTRLPLANE-3324: Enable gocyclo linter and reduce cyclomatic complexity #8309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dee133c
refactor(cli): reduce cyclomatic complexity in CLI commands
bryan-cox Apr 23, 2026
615bc5b
refactor(hypershift-operator): reduce cyclomatic complexity and enabl…
bryan-cox Apr 23, 2026
0a7a1b9
refactor(control-plane-operator): reduce cyclomatic complexity in CPO…
bryan-cox Apr 23, 2026
ec6d6d4
test(e2e): reduce cyclomatic complexity in e2e test utilities
bryan-cox Apr 23, 2026
d18fc25
fix: address review feedback on complexity refactoring PR
bryan-cox May 4, 2026
42a657c
fix: pin gocyclo threshold and add nil guard for managementClusterNet…
bryan-cox May 4, 2026
f2423d3
fix: reduce cyclomatic complexity in EnsureGlobalPullSecret
bryan-cox May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ run:
allow-parallel-runners: true
linters:
enable:
- gocyclo

@cblecker cblecker May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth pinning the threshold explicitly? The PR description says 30, but this relies on golangci-lint's default. Something like a gocyclo entry under settings: with min-complexity: 30 would make the intent self-documenting and protect against upstream default changes.

@bryan-cox bryan-cox May 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Pinned min-complexity: 30 under settings.gocyclo so it's self-documenting and won't drift with upstream defaults.

AI-assisted response via Claude Code

- misspell
- unparam
settings:
gocyclo:
min-complexity: 30
govet:
enable:
- nilness
Expand Down
Loading