Skip to content

OCPBUGS-85577: Update external-dns image from 1.1.0-3 to 1.2.1#8506

Open
bryan-cox wants to merge 1 commit into
openshift:mainfrom
bryan-cox:update-external-dns
Open

OCPBUGS-85577: Update external-dns image from 1.1.0-3 to 1.2.1#8506
bryan-cox wants to merge 1 commit into
openshift:mainfrom
bryan-cox:update-external-dns

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented May 13, 2026

Summary

  • Update the hardcoded ExternalDNS image from tag 1.1.0-3 (December 2022) to 1.2.1 (April 2026)
  • The previous image was ~3.5 years behind the latest available version

Description

The ExternalDNSImage constant in cmd/install/install.go pins a specific digest of registry.redhat.io/edo/external-dns-rhel8. The old digest corresponded to tag 1.1.0-3, published December 2022. The new digest corresponds to tag 1.2.1, the latest available version.

Note: all available versions remain amd64-only — the existing TODO for multi-arch/Arm support (NE-1298) is unchanged.

Test plan

  • Verify go build ./cmd/install/... passes
  • Verify unit tests pass
  • Confirm the new digest resolves correctly: skopeo inspect docker://registry.redhat.io/edo/external-dns-rhel8@sha256:9f60c682b44497d9736a04991c0d2b3485d477f6c89a87c4a44a211a3d1f3cd4

Summary by CodeRabbit

  • Chores
    • Updated the external-dns image reference to version 1.2.1.

The hardcoded ExternalDNS image referenced tag 1.1.0-3, published in
December 2022. Update to 1.2.1, the latest available version.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 13, 2026

@bryan-cox: This pull request references Jira Issue OCPBUGS-85577, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Update the hardcoded ExternalDNS image from tag 1.1.0-3 (December 2022) to 1.2.1 (April 2026)
  • The previous image was ~3.5 years behind the latest available version

Description

The ExternalDNSImage constant in cmd/install/install.go pins a specific digest of registry.redhat.io/edo/external-dns-rhel8. The old digest corresponded to tag 1.1.0-3, published December 2022. The new digest corresponds to tag 1.2.1, the latest available version.

Note: all available versions remain amd64-only — the existing TODO for multi-arch/Arm support (NE-1298) is unchanged.

Test plan

  • Verify go build ./cmd/install/... passes
  • Verify unit tests pass
  • Confirm the new digest resolves correctly: skopeo inspect docker://registry.redhat.io/edo/external-dns-rhel8@sha256:9f60c682b44497d9736a04991c0d2b3485d477f6c89a87c4a44a211a3d1f3cd4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 54e9d222-f904-4669-af1f-333cce8cad63

📥 Commits

Reviewing files that changed from the base of the PR and between 74753b3 and 1d3015c.

📒 Files selected for processing (1)
  • cmd/install/install.go

📝 Walkthrough

Walkthrough

The ExternalDNSImage constant in the installer was updated to reference a new image digest for external-dns RHEL8. The image digest was changed from the 1.1.0-3 version (hash: 638fb6b5...f1b4b9) to the 1.2.1 version (hash: 9f60c682...f3cd4). The corresponding comment documenting the image source was also updated to reflect the new version. No changes were made to installer logic or functionality.

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the external-dns image constant from version 1.1.0-3 to 1.2.1, which matches the single file change in cmd/install/install.go.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not introduce Ginkgo tests. The repository does not use Ginkgo - it uses standard Go testing with gomega assertions. The PR only updates the ExternalDNSImage constant. Check is not applicable.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code. Tests use standard Go testing.T with Gomega assertions, not Ginkgo. Custom check requests Ginkgo code review and is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added. The PR only updates the ExternalDNSImage constant digest in cmd/install/install.go. The MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only updates ExternalDNSImage constant in cmd/install/install.go. SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates ExternalDNSImage digest constant only. No scheduling constraints, deployment manifests, or controller logic modified. Change not applicable to topology-aware scheduling checks.
Ote Binary Stdout Contract ✅ Passed PR only updates ExternalDNSImage constant digest in a library package. No process-level functions (main, init, TestMain, etc.) modified. No stdout writes added. Change is safe.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The PR only updates the ExternalDNSImage constant in cmd/install/install.go from digest 1.1.0-3 to 1.2.1. The check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 13, 2026
@bryan-cox
Copy link
Copy Markdown
Member Author

/jira refresh

@bryan-cox bryan-cox marked this pull request as ready for review May 13, 2026 19:28
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request references Jira Issue OCPBUGS-85577, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request references Jira Issue OCPBUGS-85577, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary

  • Update the hardcoded ExternalDNS image from tag 1.1.0-3 (December 2022) to 1.2.1 (April 2026)
  • The previous image was ~3.5 years behind the latest available version

Description

The ExternalDNSImage constant in cmd/install/install.go pins a specific digest of registry.redhat.io/edo/external-dns-rhel8. The old digest corresponded to tag 1.1.0-3, published December 2022. The new digest corresponds to tag 1.2.1, the latest available version.

Note: all available versions remain amd64-only — the existing TODO for multi-arch/Arm support (NE-1298) is unchanged.

Test plan

  • Verify go build ./cmd/install/... passes
  • Verify unit tests pass
  • Confirm the new digest resolves correctly: skopeo inspect docker://registry.redhat.io/edo/external-dns-rhel8@sha256:9f60c682b44497d9736a04991c0d2b3485d477f6c89a87c4a44a211a3d1f3cd4

Summary by CodeRabbit

  • Chores
  • Updated the external-dns image reference to version 1.2.1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from devguyio and sdminonne May 13, 2026 19:29
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.00%. Comparing base (1eddaf8) to head (1d3015c).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8506   +/-   ##
=======================================
  Coverage   40.00%   40.00%           
=======================================
  Files         751      751           
  Lines       92838    92838           
=======================================
  Hits        37137    37137           
  Misses      53014    53014           
  Partials     2687     2687           
Files with missing lines Coverage Δ
cmd/install/install.go 61.77% <ø> (ø)
Flag Coverage Δ
cmd-support 34.09% <ø> (ø)
cpo-hostedcontrolplane 40.56% <ø> (ø)
cpo-other 40.14% <ø> (ø)
hypershift-operator 50.53% <ø> (ø)
other 31.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Copy Markdown
Member Author

/verified by e2e

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This PR has been marked as verified by e2e.

Details

In response to this:

/verified by e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cblecker
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-gke

@cwbotbot
Copy link
Copy Markdown

Test Results

e2e-aks

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5a61e14 and 2 for PR HEAD 1d3015c in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants