NO-JIRA: build: use uv to run python tools with pip fallback#8508
NO-JIRA: build: use uv to run python tools with pip fallback#8508cblecker wants to merge 1 commit into
Conversation
Prefer `uv run --with` over `pip install --target` for codespell, gitlint, and pyyaml when uv is available, falling back to the existing pip approach when it is not. Targets remain unconditional by confining all branching to variable definitions. Assisted-by: Claude:claude-sonnet-4-6[1m]
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@cblecker: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Makefile has been updated to support conditional execution of Python-based tooling using 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/area ci-tooling |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8508 +/- ##
=======================================
Coverage 40.00% 40.00%
=======================================
Files 751 751
Lines 92838 92838
=======================================
Hits 37137 37137
Misses 53014 53014
Partials 2687 2687
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/pipeline required |
|
Scheduling tests matching the |
|
@cblecker: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
Test Resultse2e-aks
e2e-aws
|
|
@cblecker: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
uvis detected onPATH, codespell, gitlint, and pyyaml are invoked viauv run --with <pkg>==<ver>instead of being installed intohack/tools/bin/withpip install --targetuvis not available, the existing pip-based install targets are used unchanged (full fallback, no behaviour change for CI or contributors without uv)ifneqvariable block; theverify-codespell,run-gitlint, andverify-docs-navtargets themselves have zero conditionalsTest plan
make verify-codespell,make run-gitlint,make verify-docs-nav— confirm each usesuv runUV= make verify-codespell(and the other two) — confirm pip fallback still worksmake -j verify-parallel— confirm parallel execution works with both pathsUV=/custom/uv make verify-codespell— confirm override is respectedSummary by CodeRabbit
uvpackage manager with automatic fallback to traditional tooling when unavailable.