Skip to content

CNTRLPLANE-3380: docs: add aws-node-termination-handler to repositories list#8514

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:add-aws-nth-repo
May 14, 2026
Merged

CNTRLPLANE-3380: docs: add aws-node-termination-handler to repositories list#8514
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:add-aws-nth-repo

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented May 14, 2026

Summary

  • Adds openshift/aws-node-termination-handler (fork of aws/aws-node-termination-handler) to the repositories page

Test plan

  • Verify page renders correctly via mkdocs serve
  • Confirm GitHub link resolves

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added an entry for the AWS Node Termination Handler to the repositories guide.
    • Describes its role in gracefully handling EC2 instance shutdowns within Kubernetes and provides a link to the AWS upstream repository for reference.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Adds openshift/aws-node-termination-handler (fork of aws/aws-node-termination-handler) to the repositories page

Test plan

  • Verify page renders correctly via mkdocs serve
  • Confirm GitHub link resolves

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1a7110a2-acb6-4b03-8450-a441bb335ada

📥 Commits

Reviewing files that changed from the base of the PR and between 59d3d37 and bcc78ba.

⛔ Files ignored due to path filters (1)
  • docs/content/reference/aggregated-docs.md is excluded by !docs/content/reference/aggregated-docs.md
📒 Files selected for processing (1)
  • docs/content/contribute/repositories.md
✅ Files skipped from review due to trivial changes (1)
  • docs/content/contribute/repositories.md

📝 Walkthrough

Walkthrough

This change adds a single documentation entry to docs/content/contribute/repositories.md. A new row for openshift/aws-node-termination-handler was inserted into the repositories table, describing it as a tool that gracefully handles EC2 instance shutdown within Kubernetes and linking to its AWS upstream repository.

Possibly related PRs

  • openshift/hypershift#8505: Another documentation-only update that modifies the repositories reference page by adding/updating entries in the repositories table.
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding aws-node-termination-handler to the repositories documentation list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Check not applicable. PR only modifies documentation (repositories.md). No Ginkgo tests or test code modified.
Test Structure And Quality ✅ Passed Custom check is not applicable. The PR is a documentation-only change (adding an entry to a repositories table). The check targets Ginkgo test code quality, but no test files were modified in this PR.
Microshift Test Compatibility ✅ Passed This PR is a documentation-only change to repositories.md. It contains no Ginkgo e2e tests. The MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR is a documentation-only change to repos.md. The custom check applies to Ginkgo e2e tests, which are not present in this PR. Check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Documentation-only PR adding a repositories list entry. No deployment manifests, operator code, controllers, or scheduling constraints present. Check not applicable.
Ote Binary Stdout Contract ✅ Passed Documentation-only change. OTE Stdout Contract applies to executable test code, not markdown files with no executable code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Documentation-only PR with no Ginkgo e2e tests added. Custom check is not applicable to non-test documentation changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bryan-cox bryan-cox changed the title NO-JIRA: docs: add aws-node-termination-handler to repositories list CNTRLPLANE-3380: docs: add aws-node-termination-handler to repositories list May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 14, 2026

@bryan-cox: This pull request references CNTRLPLANE-3380 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds openshift/aws-node-termination-handler (fork of aws/aws-node-termination-handler) to the repositories page

Test plan

  • Verify page renders correctly via mkdocs serve
  • Confirm GitHub link resolves

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the area/documentation Indicates the PR includes changes for documentation label May 14, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 14, 2026

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Copy Markdown
Member Author

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/verified by Docs Preview

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@openshift-merge-bot openshift-merge-bot Bot merged commit ef0f64a into openshift:main May 14, 2026
20 checks passed
@bryan-cox bryan-cox deleted the add-aws-nth-repo branch May 14, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants