Skip to content

NO-JIRA: Make codecov project check informational#8655

Open
jparrill wants to merge 1 commit into
openshift:mainfrom
jparrill:codecov-informational-project
Open

NO-JIRA: Make codecov project check informational#8655
jparrill wants to merge 1 commit into
openshift:mainfrom
jparrill:codecov-informational-project

Conversation

@jparrill
Copy link
Copy Markdown
Contributor

@jparrill jparrill commented Jun 3, 2026

Summary

  • Make the codecov/project status check informational (reports but does not block merge)
  • Keep the codecov/patch check as the merge gate with an 80% target

Description

The codecov/project check produces false negatives when carryforward coverage data is stale. When a CI run on the base commit is partially cancelled, some test shards never upload fresh coverage. Codecov carries forward older, smaller snapshots for those flags. When a PR runs all 5 shards successfully against the current codebase (which may have grown significantly since the stale base data), the freshly-measured project coverage appears lower — not because the PR reduced coverage, but because previously invisible files now show their actual (lower) coverage.

This was observed in #8368 where patch coverage was 95.47% but codecov/project reported -4.46% due to 2 stale shards (cmd-support and other) on the base commit.

The patch check is a more reliable gate: it validates that new/changed lines are properly tested, regardless of base commit data quality.

Test plan

  • Verify codecov/project reports as informational (does not block tide)
  • Verify codecov/patch still blocks with 80% target

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated code coverage reporting configuration to establish clearer coverage metrics. Now sets a target of 80% coverage for patches and designates project-level coverage reporting as informational.

The codecov/project check produces false negatives when carryforward
coverage data is stale. Partially cancelled CI runs on the base commit
cause some shards to carry forward older, smaller coverage snapshots.
When the PR runs all shards successfully against the current codebase,
the freshly-measured coverage appears lower simply because previously
invisible files now show their actual coverage.

Make the project check informational so it reports but does not block
merges. Keep the patch check as the gate with an 80% target, which
validates that new/changed code is properly tested.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jparrill: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Make the codecov/project status check informational (reports but does not block merge)
  • Keep the codecov/patch check as the merge gate with an 80% target

Description

The codecov/project check produces false negatives when carryforward coverage data is stale. When a CI run on the base commit is partially cancelled, some test shards never upload fresh coverage. Codecov carries forward older, smaller snapshots for those flags. When a PR runs all 5 shards successfully against the current codebase (which may have grown significantly since the stale base data), the freshly-measured project coverage appears lower — not because the PR reduced coverage, but because previously invisible files now show their actual (lower) coverage.

This was observed in #8368 where patch coverage was 95.47% but codecov/project reported -4.46% due to 2 stale shards (cmd-support and other) on the base commit.

The patch check is a more reliable gate: it validates that new/changed lines are properly tested, regardless of base commit data quality.

Test plan

  • Verify codecov/project reports as informational (does not block tide)
  • Verify codecov/patch still blocks with 80% target

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 05da2cde-b1aa-4b1d-b675-994ccc01b145

📥 Commits

Reviewing files that changed from the base of the PR and between c135e0c and 94b3554.

📒 Files selected for processing (1)
  • codecov.yml

📝 Walkthrough

Walkthrough

This PR updates codecov.yml to add a new coverage.status configuration block. The change configures Codecov reporting by setting the project coverage context to informational mode and establishing an 80% coverage target threshold for the patch context.

Possibly related PRs

  • openshift/hypershift#8642: Directly related codecov.yml update that also modifies coverage.status and carryforward settings for project coverage checks.
🚥 Pre-merge checks | ✅ 10 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning PR adds 58+ e2e tests with IPv4 assumptions: hardcoded IPv4 CIDRs, IPv4-only CIDR detection, and hardcoded 127.0.0.1 addresses that fail in IPv6-only environments. Use GetIPAddressFamily() to detect IP family, replace hardcoded IPv4 CIDRs with correctCIDRFamily(), use ::1 instead of 127.0.0.1, and wrap IPv4-only tests with InIPv4ClusterContext() or add [Skipped:Disconnected] tag.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Make codecov project check informational' directly and concisely describes the main change in the PR, which is to update codecov.yml to set project coverage as informational.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies codecov.yml (a YAML config file), contains no Ginkgo test code or patterns, so the test stability check is not applicable.
Test Structure And Quality ✅ Passed PR only modifies codecov.yml configuration file; no Ginkgo test code changes present, so check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only codecov.yml, a code coverage configuration file, not deployment manifests, operator code, or controllers. Topology-aware scheduling check is not applicable.
No-Weak-Crypto ✅ Passed PR only modifies codecov.yml configuration file with no cryptographic code, weak crypto algorithms, custom implementations, or secret comparisons.
Container-Privileges ✅ Passed PR modifies only codecov.yml (CI/CD configuration), not container or K8s manifests; no privileged/security risk configurations present.
No-Sensitive-Data-In-Logs ✅ Passed PR modifies codecov.yml configuration file only. No logging statements that expose passwords, tokens, keys, PII, or other sensitive data are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jparrill
Copy link
Copy Markdown
Contributor Author

jparrill commented Jun 3, 2026

/area ci-tooling

@openshift-ci openshift-ci Bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Jun 3, 2026
@openshift-ci openshift-ci Bot requested review from Nirshal and enxebre June 3, 2026 08:12
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.27%. Comparing base (c135e0c) to head (94b3554).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8655   +/-   ##
=======================================
  Coverage   41.27%   41.27%           
=======================================
  Files         755      755           
  Lines       93446    93446           
=======================================
  Hits        38566    38566           
  Misses      52148    52148           
  Partials     2732     2732           
Flag Coverage Δ
cmd-support 34.86% <ø> (ø)
cpo-hostedcontrolplane 43.50% <ø> (ø)
cpo-other 42.79% <ø> (ø)
hypershift-operator 51.00% <ø> (ø)
other 31.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants