NO-JIRA: Make codecov project check informational#8655
Conversation
The codecov/project check produces false negatives when carryforward coverage data is stale. Partially cancelled CI runs on the base commit cause some shards to carry forward older, smaller coverage snapshots. When the PR runs all shards successfully against the current codebase, the freshly-measured coverage appears lower simply because previously invisible files now show their actual coverage. Make the project check informational so it reports but does not block merges. Keep the patch check as the gate with an 80% target, which validates that new/changed code is properly tested. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@jparrill: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates Possibly related PRs
🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/area ci-tooling |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8655 +/- ##
=======================================
Coverage 41.27% 41.27%
=======================================
Files 755 755
Lines 93446 93446
=======================================
Hits 38566 38566
Misses 52148 52148
Partials 2732 2732
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@jparrill: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
codecov/projectstatus check informational (reports but does not block merge)codecov/patchcheck as the merge gate with an 80% targetDescription
The
codecov/projectcheck produces false negatives when carryforward coverage data is stale. When a CI run on the base commit is partially cancelled, some test shards never upload fresh coverage. Codecov carries forward older, smaller snapshots for those flags. When a PR runs all 5 shards successfully against the current codebase (which may have grown significantly since the stale base data), the freshly-measured project coverage appears lower — not because the PR reduced coverage, but because previously invisible files now show their actual (lower) coverage.This was observed in #8368 where patch coverage was 95.47% but
codecov/projectreported -4.46% due to 2 stale shards (cmd-supportandother) on the base commit.The
patchcheck is a more reliable gate: it validates that new/changed lines are properly tested, regardless of base commit data quality.Test plan
codecov/projectreports as informational (does not block tide)codecov/patchstill blocks with 80% target🤖 Generated with Claude Code
Summary by CodeRabbit