Skip to content

CNTRLPLANE-3555: Add ARCHITECTURE.md to repository root#8668

Open
celebdor wants to merge 1 commit into
openshift:mainfrom
celebdor:CNTRLPLANE-3555/architecture-md
Open

CNTRLPLANE-3555: Add ARCHITECTURE.md to repository root#8668
celebdor wants to merge 1 commit into
openshift:mainfrom
celebdor:CNTRLPLANE-3555/architecture-md

Conversation

@celebdor
Copy link
Copy Markdown
Collaborator

@celebdor celebdor commented Jun 4, 2026

Summary

  • Adds ARCHITECTURE.md to satisfy the HPSTRAT-6 contextification initiative, which requires every active repo to have README.md, CONTRIBUTING.md, AGENTS.md, and ARCHITECTURE.md
  • Concise overview (~50 lines) covering purpose, key concepts, core components, design invariants, and platform support
  • Links to detailed docs in docs/content/reference/ rather than duplicating content

Jira

  • Feature: OCPSTRAT-3200 — [Control Plane] Phase 1: Contextification
  • Epic: CNTRLPLANE-3554 — HyperShift Contextification — Repo Context Files
  • Story: CNTRLPLANE-3555 — Add ARCHITECTURE.md to the hypershift repository

Test plan

  • File renders correctly on GitHub (plain markdown, no Mermaid)
  • All relative links to docs pages resolve correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Added comprehensive Architecture documentation detailing design principles, key concepts, core components, and platform support information.

Part of the Hybrid Platforms contextification initiative (HPSTRAT-6)
which requires every active repo to have README.md, CONTRIBUTING.md,
AGENTS.md, and ARCHITECTURE.md.

This file provides a concise architectural overview covering the core
components, design invariants, and platform support, with links to
detailed documentation in docs/content/reference/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 4, 2026

@celebdor: This pull request references CNTRLPLANE-3555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds ARCHITECTURE.md to satisfy the HPSTRAT-6 contextification initiative, which requires every active repo to have README.md, CONTRIBUTING.md, AGENTS.md, and ARCHITECTURE.md
  • Concise overview (~50 lines) covering purpose, key concepts, core components, design invariants, and platform support
  • Links to detailed docs in docs/content/reference/ rather than duplicating content

Jira

  • Feature: OCPSTRAT-3200 — [Control Plane] Phase 1: Contextification
  • Epic: CNTRLPLANE-3554 — HyperShift Contextification — Repo Context Files
  • Story: CNTRLPLANE-3555 — Add ARCHITECTURE.md to the hypershift repository

Test plan

  • File renders correctly on GitHub (plain markdown, no Mermaid)
  • All relative links to docs pages resolve correctly

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Jun 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 114f494a-c7af-454e-b2ec-3a173a992c97

📥 Commits

Reviewing files that changed from the base of the PR and between e25a87a and fdfcdb6.

📒 Files selected for processing (1)
  • ARCHITECTURE.md

📝 Walkthrough

Walkthrough

This pull request adds a new ARCHITECTURE.md file to the HyperShift repository. The document provides an overview of HyperShift's architecture, explaining its role as middleware for hosting OpenShift control planes at scale. It introduces key concepts, documents core components with their directory locations and responsibilities, describes design invariants, lists supported platforms, and includes links to further reading resources.

Suggested reviewers

  • csrwng
  • cblecker

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Container-Privileges ❌ Error PR adds Kubernetes manifests with privileged configs: kubelet daemonset (hostPID, hostNetwork, privileged), CSI daemonset (privileged, allowPrivilegeEscalation), and e2e test pod (privileged). Verify privilege escalation in added manifests has appropriate security justifications and follows least-privilege principles for production.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding ARCHITECTURE.md to the repository root, which is the primary objective of this pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds only ARCHITECTURE.md (documentation). No test files or Ginkgo test patterns modified; check is not applicable to documentation-only changes.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test quality is not applicable; PR contains only documentation changes (ARCHITECTURE.md) with no test code modifications.
Topology-Aware Scheduling Compatibility ✅ Passed This PR adds only ARCHITECTURE.md, a documentation-only file. The custom check applies to deployment manifests, operator code, or controllers—none of which are modified in this change.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed New Ginkgo e2e tests show no IPv4-only addresses, proper IPv6-compatible URL building with net.JoinHostPort, and no external connectivity requirements.
No-Weak-Crypto ✅ Passed PR adds only ARCHITECTURE.md documentation with no code changes. The weak-crypto check is not applicable to documentation-only changes.
No-Sensitive-Data-In-Logs ✅ Passed ARCHITECTURE.md contains no passwords, tokens, API keys, PII, session IDs, or customer data; only architectural documentation with descriptive references to credentials.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celebdor
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.44%. Comparing base (e25a87a) to head (fdfcdb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8668   +/-   ##
=======================================
  Coverage   41.44%   41.44%           
=======================================
  Files         756      756           
  Lines       93644    93644           
=======================================
  Hits        38807    38807           
  Misses      52114    52114           
  Partials     2723     2723           
Flag Coverage Δ
cmd-support 34.87% <ø> (ø)
cpo-hostedcontrolplane 43.50% <ø> (ø)
cpo-other 42.79% <ø> (ø)
hypershift-operator 51.56% <ø> (ø)
other 31.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@celebdor celebdor added area/ci-tooling Indicates the PR includes changes for CI or tooling area/ai Indicates the PR includes changes related to AI - Claude agents, Cursor rules, etc. labels Jun 4, 2026
@celebdor celebdor marked this pull request as ready for review June 4, 2026 12:39
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2026
@openshift-ci openshift-ci Bot requested review from bryan-cox and csrwng June 4, 2026 12:40
@bryan-cox
Copy link
Copy Markdown
Member

bryan-cox commented Jun 4, 2026

/hold

For internal discussion if we need this or not

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

@celebdor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Jun 4, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@bryan-cox
Copy link
Copy Markdown
Member

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ai Indicates the PR includes changes related to AI - Claude agents, Cursor rules, etc. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants