OSASINFRA-4368: Update CAPO to latest stable release#8687
Open
stephenfin wants to merge 2 commits into
Open
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request references OSASINFRA-4368 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (125)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates go.mod to use github.com/k-orc/openstack-resource-controller/v2 and bumps cluster-api and controller-runtime versions. Import paths in several files were changed to the v2 API. Code and tests were updated to use the v2 types: ImageResourceSpec.Name is passed as a pointer to orc.OpenStackName and PrefixedClusterImageName now returns orc.OpenStackName. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 126: The go.mod lists "sigs.k8s.io/controller-runtime v0.22.5" in the
require section but also has a "replace sigs.k8s.io/controller-runtime =>
sigs.k8s.io/controller-runtime v0.19.7", so the replace overrides the bump;
reconcile by either removing the replace directive or updating it to match
v0.22.5 (or update the require to v0.19.7 if that older version is mandatory),
and add a short comment in go.mod explaining why a replace is necessary when
forcing v0.19.7 (or why the replace was removed) so future readers understand
the decision; search for the "require sigs.k8s.io/controller-runtime" and
"replace sigs.k8s.io/controller-runtime" entries to make the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 01ba8e69-ed4b-414a-850d-ee2c14ba53f8
⛔ Files ignored due to path filters (33)
go.sumis excluded by!**/*.sumvendor/modules.txtis excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1alpha1/openstackclusteridentity_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1alpha1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/conditions_consts.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/identity_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/openstackcluster_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/openstackmachine_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/openstackmachinetemplate_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/errors/errors.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/errors/terminal.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta1/cluster_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta1/conversion.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta1/machine_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta1/zz_generated.conversion.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/sigs.k8s.io/cluster-api/api/core/v1beta1/zz_generated.openapi.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/cluster_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/clusterclass_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/common_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/machine_phase_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/machine_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/machinehealthcheck_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/machineset_types.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/v1beta1_condition_consts.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/zz_generated.deepcopy.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/sigs.k8s.io/cluster-api/api/core/v1beta2/zz_generated.openapi.gois excluded by!vendor/**,!**/vendor/**,!**/zz_generated*.go,!**/zz_generated*vendor/sigs.k8s.io/cluster-api/feature/feature.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/util/conditions/sort.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/util/patch/patch.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/util/patch/utils.gois excluded by!vendor/**,!**/vendor/**vendor/sigs.k8s.io/cluster-api/util/util.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (1)
go.mod
openshift-ci
Bot
added
area/cli
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8687 +/- ##
=======================================
Coverage 41.43% 41.43%
=======================================
Files 756 756
Lines 93647 93647
=======================================
Hits 38802 38802
Misses 52124 52124
Partials 2721 2721
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: muraee, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
CAPO was bumped first: go get sigs.k8s.io/cluster-api-provider-openstack@latest go mod tidy go mod vendor Followed by ORC, which is bumped to a new major version: go get sigs.k8s.io/cluster-api-provider-openstack/v2@latest All imports are updated accordingly. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
openshift-ci
Bot
added
area/control-plane-operator
Contributor
|
@stephenfin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bump the version of CAPO used in Hypershift to the latest stable version, 0.14.x.
Which issue(s) this PR fixes:
Fixes OSASINFRA-4368
Special notes for your reviewer:
Checklist:
Summary by CodeRabbit