CNF-23049: Migrate away from deprecated ioutil

[sebrandon1]

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Core refactoring: Replace ioutil usage with io and os equivalents

• Replaced all instances of ioutil.ReadFile with os.ReadFile for reading files, and ioutil.WriteFile with os.WriteFile for writing files in multiple files, such as dockerregistry.go, config.go, and their respective test files. [1] [2] [3] [4] [5] [6]
• Replaced all instances of ioutil.ReadAll with io.ReadAll for reading from readers and response bodies, affecting HTTP handlers, test helpers, and utility functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
• Replaced ioutil.TempDir with os.MkdirTemp for creating temporary directories in tests. [1] [2]
• Replaced ioutil.Discard with io.Discard for discarding output in logger setup.
• Removed deprecated ioutil import statements and updated import blocks accordingly across all affected files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

These changes ensure the codebase is compatible with newer Go versions and follows up-to-date language standards.

[flavianmissi]

Thanks for taking the time to do this, @sebrandon1!

/lgtm
/retitle NO-JIRA: Migrate away from deprecated ioutil

[openshift-ci-robot]

@sebrandon1: This pull request explicitly references no jira issue.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Core refactoring: Replace ioutil usage with io and os equivalents

• Replaced all instances of ioutil.ReadFile with os.ReadFile for reading files, and ioutil.WriteFile with os.WriteFile for writing files in multiple files, such as dockerregistry.go, config.go, and their respective test files. [1] [2] [3] [4] [5] [6]
• Replaced all instances of ioutil.ReadAll with io.ReadAll for reading from readers and response bodies, affecting HTTP handlers, test helpers, and utility functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
• Replaced ioutil.TempDir with os.MkdirTemp for creating temporary directories in tests. [1] [2]
• Replaced ioutil.Discard with io.Discard for discarding output in logger setup.
• Removed deprecated ioutil import statements and updated import blocks accordingly across all affected files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

These changes ensure the codebase is compatible with newer Go versions and follows up-to-date language standards.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[flavianmissi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, sebrandon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [flavianmissi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flavianmissi]

this is an internal change.
/label px-approved
/label docs-approved

[openshift-ci]

New changes are detected. LGTM label has been removed.

[sebrandon1]

/retest

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-23049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Core refactoring: Replace ioutil usage with io and os equivalents

• Replaced all instances of ioutil.ReadFile with os.ReadFile for reading files, and ioutil.WriteFile with os.WriteFile for writing files in multiple files, such as dockerregistry.go, config.go, and their respective test files. [1] [2] [3] [4] [5] [6]
• Replaced all instances of ioutil.ReadAll with io.ReadAll for reading from readers and response bodies, affecting HTTP handlers, test helpers, and utility functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
• Replaced ioutil.TempDir with os.MkdirTemp for creating temporary directories in tests. [1] [2]
• Replaced ioutil.Discard with io.Discard for discarding output in logger setup.
• Removed deprecated ioutil import statements and updated import blocks accordingly across all affected files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

These changes ensure the codebase is compatible with newer Go versions and follows up-to-date language standards.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Warning

Rate limit exceeded

@sebrandon1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 11 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8406ffeb-c4d6-4bbe-a090-135db47aa21c

📥 Commits

Reviewing files that changed from the base of the PR and between 57039cd and 51e4a13.

📒 Files selected for processing (15)

• pkg/cmd/dockerregistry/dockerregistry.go
• pkg/dockerregistry/server/blobdescriptorservice_test.go
• pkg/dockerregistry/server/configuration/configuration.go
• pkg/dockerregistry/server/signaturedispatcher.go
• pkg/dockerregistry/server/signaturedispatcher_test.go
• pkg/dockerregistry/server/util_test.go
• pkg/kubernetes-common/credentialprovider/config.go
• pkg/kubernetes-common/credentialprovider/config_test.go
• pkg/origin-common/clientcmd/clientcmd.go
• pkg/testframework/registry.go
• pkg/testutil/logrus.go
• test/integration/imagelayers/imagelayers_test.go
• test/integration/pullthrough/pullthrough_test.go
• test/integration/v2/v2_docker_registry_test.go
• tools/import-verifier/import-verifier.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 0/10 reviews remaining, refill in 2 minutes and 11 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.