Skip to content

Updates to improve local dev usability #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bdematte wants to merge 1 commit into from
Closed

Updates to improve local dev usability #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile.aro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#
ARG REGISTRY=registry.access.redhat.com
ARG BUILDER_REGISTRY=registry.ci.openshift.org/ocp/builder
FROM ${BUILDER_REGISTRY}:rhel-9-golang-1.24-openshift-4.20 AS builder
FROM --platform=linux/amd64 ${BUILDER_REGISTRY}:rhel-9-golang-1.24-openshift-4.20 AS builder

ENV GO_COMPLIANCE_INFO=0
USER root
Expand All @@ -16,7 +16,7 @@ COPY . /app
RUN git config --system --add safe.directory '*'
RUN make aro RELEASE=${IS_OFFICIAL_RELEASE} -o generate && make validate-fips

FROM ${REGISTRY}/ubi9/ubi-minimal
FROM --platform=linux/amd64 ${REGISTRY}/ubi9/ubi-minimal
RUN microdnf update -y && microdnf clean all -y
COPY --from=builder /app/aro /bin/openshift-install
ENTRYPOINT ["/bin/openshift-install"]
Expand Down
29 changes: 29 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Test paragraph

You can build and publish to your personal Quay account installer-aro-wrapper image with as follow:
```
export ARO_IMAGE=quay.io/<your_account>/aroinstaller:<image_tag>
make publish-image-aro
```

For the build step to succeed, we are now pulling images from quay.io/openshift-release-dev and they aren't publicly available. So we need to have extra auth for docker/pod
man. Needed information can be found in `secrets/env` in ARO-RP.
Note `secrets` repository isn't commited and is retrieved with `make secrets` command (details in ARO-RP documentation).
The needed token is the one used for 'quay.io' in the `PULL_SECRET` environment variable.

To be able to pull images for build and push your image afterward to your own account, `auth.json` should be something like
```
{
"auths": {
"arointsvc.azurecr.io": {
"auth": "<redacted_token>"
},
"quay.io/<your_account>": {
"auth": "<redacted_token>"
},
"quay.io/openshift-release-dev": {
"auth": "<redacted_token_from_ARO-rp>"
}
}
}
```