Remove vendor gowork 4.17 #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry-pick-301-to-release-4.17 [release-4.17] Bumping up fluentbit base image to latest
…ry-pick-308-to-release-4.17 [release-4.17] [ARO-9688] Move to partner-share-openshift image for builds, add fips-detect to validate our FIPS building
…ry-pick-317-to-release-4.17 [release-4.17] [ARO-19962] Update to go 1.24, golangci-lint, and run --fix
…ry-pick-324-to-release-4.17 [release-4.17] [ARO-20321] Don't check for availability zones in bad regions (like centraluseuap)
- Updated golang.org/x/net from v0.35.0 to v0.38.0 to fix: - GHSA-qxp5-gwg8-xv66 - GHSA-vvgc-356p-c3xw (CVE-2025-22872) - Updated github.com/golang-jwt/jwt/v4 from v4.5.1 to v4.5.2 to fix: - GHSA-mh63-6h87-95cp - Updated github.com/golang-jwt/jwt/v5 from v5.2.1 to v5.2.2 to fix: - GHSA-mh63-6h87-95cp (same vulnerability affects both v4 and v5) - Updated related dependencies (x/crypto, x/sync, x/sys, x/term, x/text) - Updated vendor directory to match dependency changes System library vulnerabilities (glibc, krb5, libxml2) will be fixed on image rebuild.
…ease-4.17 ARO-21088: Installer vulnerabilities September 2025 - 4.17
…ry-pick-347-to-release-4.17 [release-4.17] Add red-hat-managed: true tag to install-config
This reverts commit 326633f.
…ry-pick-353-to-release-4.17 [release-4.17] Revert "Add red-hat-managed: true tag to install-config"
Split image configuration into granular build args for better flexibility: Builder image args: - BUILDER_REGISTRY (default: registry.ci.openshift.org) - BUILDER_REPOSITORY (default: ocp/builder) - BUILDER_TAG (default: rhel-9-golang-1.24-openshift-4.20) Base image args: - REGISTRY (default: registry.access.redhat.com) - REPOSITORY (default: ubi9/ubi-minimal) - TAG (default: latest) This allows customizing individual components (registry, repository, or tag) without modifying the Dockerfile, making it more flexible for different environments (e.g., using MCR images for OneBranch pipelines). Defaults maintain existing behavior.
…ry-pick-359-to-release-4.17 [release-4.17] Make builder and base images configurable via build args
…ry-pick-329-to-release-4.17 [release-4.17] ARO-14269 Fluentbit update to latest support version 4.0.4
…ry-pick-316-to-release-4.17 [release-4.17] ARO-14269 Fluentbit update to latest support version 4.0.4
openshift-merge-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shubhadapaithankar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The go.work and go.work.sum files were accidentally included when vendoring the Azure SDK azidentity package. These files cause build failures with "directory cmd/aro is contained in a module that is not one of the workspace modules listed in go.work" error. Removing these files fixes the build.
shubhadapaithankar
force-pushed
the
remove-vendor-gowork-4.17
branch
from
1fe2400 to
88cef6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go.workandgo.work.sumfiles were accidentally included when vendoring the Azure SDK azidentity package. These files cause build failures with:directory cmd/aro is contained in a module that is not one of the workspace modules listed in go.workRemoving these files fixes the build.
This is blocking the OneBranch installer image build pipeline.