no-jira: PowerVS: Remove unrequired logging

[AshwinHIBM]

Logging too many details makes the output cluttered. This PR reduces some unrequired logging.

Summary by CodeRabbit

• Chores
  • Removed an internal debug log from the PowerVS provisioning workflow.

[coderabbitai]

Walkthrough

The PR removes a single debug log statement from the PostProvision method in the PowerVS provider, emitted after the PowerVS configuration client is created. No functional logic, control flow, or error handling is affected.

Changes

Debug Log Removal

Layer / File(s)	Summary
PostProvision debug log pkg/infrastructure/powervs/clusterapi/powervs.go	The debug log logrus.Debugf("PostProvision: NewClient returns %+v", client) is removed immediately after powervsconfig.NewClient() is called in the PostProvision method.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❌ Error	Dynamic test name found in pkg/destroy/powervs/powervs_test.go line 141: fmt.Sprintf("attempt_%d", tt.attempt) creates unstable names like "attempt_0", "attempt_1".	Use static test names. Replace fmt.Sprintf("attempt_%d", tt.attempt) with a constant or struct field name. Move attempt number to test body.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Test Structure And Quality	✅ Passed	This PR removes debug logging from production code. No test files are modified or added. The custom check reviews Ginkgo test code and is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. Check requires Ginkgo test additions (It(), Describe(), etc.) which did not occur in this PR.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests added in this PR. The change only removes a debug log statement from PowerVS infrastructure provider code. SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Removes debug log from PowerVS infrastructure code. No scheduling constraints, affinity rules, or topology-dependent configurations added.
Ote Binary Stdout Contract	✅ Passed	PostProvision is application code, not process-level code. Logrus writes to stderr via hooks configured in main.go. No stdout corruption occurs. Change complies with OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies production code to remove a debug log, not add new Ginkgo e2e tests. The custom check only applies when new tests are added. Not applicable.
Title check	✅ Passed	The title clearly and specifically describes the main change: removing unnecessary logging from the PowerVS provider.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[AshwinHIBM]

/test e2e-powervs-capi-ovn

[prb112]

/lgtm

[openshift-ci]

@AshwinHIBM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-powervs-capi-ovn	49e783c	link	false	/test e2e-powervs-capi-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

/retitle no-jira: PowerVS: Remove unrequired logging

[openshift-ci-robot]

@AshwinHIBM: This pull request explicitly references no jira issue.

Details

In response to this:

Logging too many details makes the output cluttered. This PR reduces some unrequired logging.

Summary by CodeRabbit

• Chores
• Removed an internal debug log from the PowerVS provisioning workflow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prb112, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/infrastructure/powervs/OWNERS [tthvo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prb112]

Hey @mjturek you okay to mark /verified?

[AshwinHIBM]

/verified by @AshwinHIBM

[openshift-ci-robot]

@AshwinHIBM: This PR has been marked as verified by @AshwinHIBM.

Details

In response to this:

/verified by @AshwinHIBM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD c5e380f and 2 for PR HEAD 49e783c in total

[AshwinHIBM]

/cherry-pick release-4.22

[openshift-cherrypick-robot]

@AshwinHIBM: new pull request created: #10583

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.