NO-JIRA: image-references should reference aws-karpenter-provider-aws#7
NO-JIRA: image-references should reference aws-karpenter-provider-aws#7maxcao13 wants to merge 1 commit intoopenshift:mainfrom
Conversation
The image references should reference the actual karpenter image in the payload. Signed-off-by: Max Cao <macao@redhat.com>
|
@maxcao13: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesImageStream Tag Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test e2e-aws seems like a infra flake, we aren't even including the image in the payload yet. |
|
/test e2e-aws |
|
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The image references should reference the actual karpenter image in the payload.
We're enable to promote a built release payload image including the karpenter-operator because one of the image-references didn't exist: openshift/release#79001. It should reference
aws-karpenter-provider-awswhich actually does exist in the payload.Summary by CodeRabbit