HOSTEDCP-2207: Add filewatcher to library-go

[bryan-cox]

Filewatcher was initially created during development of HyperShift's managed Azure service. Due to the Azure Cloud API authentication type used by this service, client certificate, whenever the certificate rotates, the pod needs to reauthenticate with Azure since Azure SDK for Go currently does not support re-authenticating with Azure with the new certificate.

This functionality was individually added to several OpenShift repos - CNCC, CIO, and CIRO - through the PRs mentioned below:

• HOSTEDCP-2035: Use Client Cert Auth for ARO HCP deployments cloud-network-config-controller#156
• HOSTEDCP-2031: Use Client Certificate Authentication for ARO HCP deployments cluster-ingress-operator#1151
• HOSTEDCP-1994: Add filewatcher for Azure client certificate authentication cluster-image-registry-operator#1155

These repos should use the same codebase for this functionality rather than having 3 different instances of filewatcher.

[openshift-ci-robot]

@bryan-cox: This pull request references HOSTEDCP-2207 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Filewatcher was initially created during development of HyperShift's managed Azure service. Due to the Azure Cloud API authentication type used by this service, client certificate, whenever the certificate rotates, the pod needs to reauthenticate with Azure since Azure SDK for Go currently does not support re-authenticating with Azure with the new certificate.

This functionality was individually added to several OpenShift repos - CNCC, CIO, and CIRO - through the PRs mentioned below:

• HOSTEDCP-2035: Use Client Cert Auth for ARO HCP deployments cloud-network-config-controller#156
• HOSTEDCP-2031: Use Client Certificate Authentication for ARO HCP deployments cluster-ingress-operator#1151
• HOSTEDCP-1994: Add filewatcher for Azure client certificate authentication cluster-image-registry-operator#1155

These repos should use the same codebase for this functionality rather than having 3 different instances of filewatcher.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

cc: @bennerv

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[p0lyn0mial]

I think that library-go already has this feature. Please take a look at

library-go/pkg/operator/watchdog/cmd.go

Line 98 in 8c1789c

func NewFileWatcherWatchdog() *cobra.Command {

For a sample usage example, you can check https://github.com/openshift/cluster-samples-operator/blob/master/manifests/06-operator.yaml#L82

Additionally, the feature provided by the library includes support for graceful termination, which this PR does not appear to offer.

[bryan-cox]

/close

We won't need this with the new authentication method being introduced in CNTRLPLANE-103

[openshift-ci]

@bryan-cox: Closed this PR.

Details

In response to this:

/close

We won't need this with the new authentication method being introduced in CNTRLPLANE-103

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.