OCPBUGS-84536: Update MakeServerCert to use time.Duration instead of days

[jubittajohn]

Backport of #2155 fix for the bug) and #2182 test for the code change).

library-go crypto MakeSelfSignedCA and MakeServerCert were updated to use time.Duration instead of days, Update MakeServerCert() call in AddDefaultRotationToConfig() to reflect this change (#1943 that introduced this change)

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 854759e6-30f4-457a-b093-e54710b89bf5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@jubittajohn: This pull request references Jira Issue OCPBUGS-84536, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-84536 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #2155 fix for the bug) and #2182 test for the code change).

library-go crypto MakeSelfSignedCA and MakeServerCert were updated to use time.Duration instead of days, Update MakeServerCert() call in AddDefaultRotationToConfig() to reflect this change (#1943 that introduced this change)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[p0lyn0mial]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jubittajohn, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jubittajohn: Jira Issue OCPBUGS-84536: All pull requests linked via external trackers have merged:

• openshift/library-go#2183

Jira Issue OCPBUGS-84536 has been moved to the MODIFIED state.

Details

In response to this:

Backport of #2155 fix for the bug) and #2182 test for the code change).

library-go crypto MakeSelfSignedCA and MakeServerCert were updated to use time.Duration instead of days, Update MakeServerCert() call in AddDefaultRotationToConfig() to reflect this change (#1943 that introduced this change)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in release 4.22.0-0.nightly-2026-05-04-220841