[release-4.21] OCPBUGS-85270: fsync static pod cert and manifest writes for crash durability by openshift-cherrypick-robot · Pull Request #2204 · openshift/library-go

openshift-cherrypick-robot · 2026-05-07T16:27:45Z

This is an automated cherry-pick of #2176

/assign openshift-ci-robot

atomicdir.Sync writes files to a staging directory, atomically swaps it with the target directory via renameat2(RENAME_EXCHANGE), then deletes the old data. Without fsync, file data lives only in the kernel page cache. On ungraceful shutdown the journal replays the swap and deletion (metadata), but the file data was never flushed, leaving truncated or empty files. Introduce an fsutil package with WriteFileFsync (write + fsync file + fsync parent directory) and Fsync (fsync a path) primitives. Use WriteFileFsync for all file writes so each file is individually durable, and fsync both parent directories after the swap to persist which inode each directory name points to.

writePod uses bare os.WriteFile plus a delete-then-write pattern for kubelet manifests. On ungraceful shutdown, the delete is journaled but the new file data may not have reached disk, leaving the manifest missing. Replace os.WriteFile with fsutil.WriteFileFsync, which writes, fsyncs the file, and fsyncs the parent directory in a single call, ensuring both the resource copy and the kubelet manifest are durable before the function returns.

openshift-ci-robot · 2026-05-07T16:27:50Z

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-84258 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.21] OCPBUGS-85270: fsync static pod cert and manifest writes for crash durability

Details

In response to this:

This is an automated cherry-pick of #2176

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-07T16:27:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 25a4cb39-d031-4167-973a-bbcf104ed529

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-05-07T16:28:10Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-85270, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-85269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2176

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-07T16:49:46Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

sanchezl · 2026-05-07T19:47:57Z

/jira refresh

openshift-ci-robot · 2026-05-07T19:48:02Z

@sanchezl: This pull request references Jira Issue OCPBUGS-85270, which is invalid:

expected dependent Jira Issue OCPBUGS-85269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sanchezl · 2026-05-12T18:55:24Z

/jira refresh

openshift-ci-robot · 2026-05-12T18:55:29Z

@sanchezl: This pull request references Jira Issue OCPBUGS-85270, which is invalid:

expected dependent Jira Issue OCPBUGS-85269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sanchezl · 2026-05-13T01:56:11Z

/jira refresh

openshift-ci-robot · 2026-05-13T01:56:16Z

@sanchezl: This pull request references Jira Issue OCPBUGS-85270, which is invalid:

expected dependent Jira Issue OCPBUGS-85269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sanchezl · 2026-05-14T18:14:31Z

/jira refresh

openshift-ci-robot · 2026-05-14T18:14:37Z

@sanchezl: This pull request references Jira Issue OCPBUGS-85270, which is invalid:

expected dependent Jira Issue OCPBUGS-85269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sanchezl

/lgtm

p0lyn0mial · 2026-05-15T07:11:31Z

/approve

openshift-ci · 2026-05-15T07:12:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, p0lyn0mial, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/operator/staticpod/OWNERS~~ [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sanchezl · 2026-05-15T14:59:04Z

/jira refresh

openshift-ci-robot · 2026-05-15T14:59:09Z

@sanchezl: This pull request references Jira Issue OCPBUGS-85270, which is invalid:

expected dependent Jira Issue OCPBUGS-85269 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sanchezl added 2 commits May 7, 2026 16:27

openshift-cherrypick-robot assigned openshift-ci-robot May 7, 2026

openshift-cherrypick-robot mentioned this pull request May 7, 2026

OCPBUGS-84258: fsync static pod cert and manifest writes for crash durability #2176

Merged

4 tasks

openshift-ci Bot changed the title ~~[release-4.21] OCPBUGS-84258: fsync static pod cert and manifest writes for crash durability~~ [release-4.21] OCPBUGS-85270: fsync static pod cert and manifest writes for crash durability May 7, 2026

openshift-ci Bot requested review from dgrisonnet and p0lyn0mial May 7, 2026 16:29

sanchezl mentioned this pull request May 7, 2026

[release-4.21] OCPBUGS-85270: fsync static pod cert and manifest writes for crash durability openshift/cluster-kube-apiserver-operator#2144

Open

sanchezl approved these changes May 14, 2026

View reviewed changes

openshift-ci Bot assigned sanchezl May 14, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026

Conversation

openshift-cherrypick-robot commented May 7, 2026

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

coderabbitai Bot commented May 7, 2026

Review skipped

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

openshift-ci Bot commented May 7, 2026

Uh oh!

sanchezl commented May 7, 2026

Uh oh!

openshift-ci-robot commented May 7, 2026

Uh oh!

sanchezl commented May 12, 2026

Uh oh!

openshift-ci-robot commented May 12, 2026

Uh oh!

sanchezl commented May 13, 2026

Uh oh!

openshift-ci-robot commented May 13, 2026

Uh oh!

sanchezl commented May 14, 2026

Uh oh!

openshift-ci-robot commented May 14, 2026

Uh oh!

sanchezl left a comment

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented May 15, 2026

Uh oh!

openshift-ci Bot commented May 15, 2026

Uh oh!

sanchezl commented May 15, 2026

Uh oh!

openshift-ci-robot commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants