OCPBUGS-87161: [release-4.22] OCPBUGS-87027: MCO-2212: MCO-2213: Migrate mco_observability and mco_daemon test-suite by ptalgulk01 · Pull Request #6143 · openshift/machine-config-operator

ptalgulk01 · 2026-06-04T05:46:52Z

Manual cherry-pick #5875

…rivate Migrated 15 tests from openshift-tests-private to machine-config-operator test suite under the longduration suite. Tests migrated from mco_observability.go (7 tests): - 43151: add node label to service monitor - 46424: Check run level - 51219: Check ClusterRole rules - 54937: logs and events are flood with clusterrole and clusterrolebinding - 54974: silence audit log events for container infra - 56706: Move MCD drain alert into the MCC, revisit error mode - 68683: nodelogs feature works fine Tests migrated from mco_daemon.go (8 tests): - 43084: shutdown machine config daemon with SIGTERM - 42704: disable auto reboot for mco - 43085: check mcd crash-loop-back-off error in log - 68687: HostToContainer propagation in MCD - 68688: kubeconfig must have 600 permissions in all nodes - 69091: Machine-Config-Operator skips reboot when configuration matches during node bootstrap pivot - 68682: daemon should not pull baremetalRuntimeCfg every time - 68686: MCD No invalid memory address or nil pointer dereference when kubeconfig file is not present in a node Added helper functions and constants: - Platform constants: AlibabaCloudPlatform, OpenstackPlatform, OvirtPlatform, NutanixPlatform, OnPremPlatforms - MachineConfig constants: MachineConfigOperator, MachineConfigDaemonEvents - Utility functions: containsMultipleStrings, WrapWithBracketsIfIpv6, skipTestIfNotIPI, IsInstalledWithAssistedInstallerOrFail, IsOnPremPlatform, SkipIfNotOnPremPlatform, getSATokenFromContainer, getHostFromRoute, getPrometheusQueryResults, getMachineConfigOperatorPod, getAlertsByName, ToInterfaceSlice - Controller methods: GetLogsAsList, GetFilteredLogsAsList, GetFilteredLogs - Node methods: GetJournalLogs, GetAllCoreOsNodesOrFail, FilterSchedulableNodesOrFail Copied template files: - create-pod.yaml - add-mc-to-trigger-node-drain.yaml - pod-disruption-budget.yaml Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

openshift-merge-bot · 2026-06-04T05:46:54Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-06-04T05:46:58Z

@ptalgulk01: This pull request references Jira Issue OCPBUGS-87027, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "5.0.0" instead
expected Jira Issue OCPBUGS-87027 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick #5875

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-04T05:49:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ac11fbc7-b55a-46aa-8898-a8dadddb9c49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

isabella-janssen · 2026-06-04T14:59:26Z

/jira cherrypick OCPBUGS-87027

openshift-ci-robot · 2026-06-04T15:00:37Z

@isabella-janssen: Jira Issue OCPBUGS-87027 has been cloned as Jira Issue OCPBUGS-87161. Will retitle bug to link to clone.
/retitle OCPBUGS-87161: [release-4.22] OCPBUGS-87027: MCO-2212: MCO-2213: Migrate mco_observability and mco_daemon test-suite

Details

In response to this:

/jira cherrypick OCPBUGS-87027

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-04T15:00:46Z

@ptalgulk01: This pull request references Jira Issue OCPBUGS-87161, which is invalid:

expected dependent Jira Issue OCPBUGS-87027 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick #5875

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-06-04T15:01:56Z

/jira refresh

openshift-ci-robot · 2026-06-04T15:02:04Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-87161, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-87027 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-87027 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen

/lgtm
/label backport-risk-assessed

Looks like a clean BP and this should be safe since it is just adding tests to our longrunning suite

openshift-merge-bot · 2026-06-04T19:23:11Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

openshift-ci · 2026-06-04T19:23:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, ptalgulk01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ptalgulk01 · 2026-06-05T06:26:14Z

/test unit

ptalgulk01 · 2026-06-05T06:41:37Z

/retest

openshift-ci · 2026-06-05T10:05:35Z

@ptalgulk01: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2026

openshift-ci Bot requested review from RishabhSaini and cheesesashimi June 4, 2026 05:47

openshift-ci Bot changed the title ~~[release-4.22] OCPBUGS-87027: MCO-2212: MCO-2213: Migrate mco_observability and mco_daemon test-suite~~ OCPBUGS-87161: [release-4.22] OCPBUGS-87027: MCO-2212: MCO-2213: Migrate mco_observability and mco_daemon test-suite Jun 4, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2026

isabella-janssen reviewed Jun 4, 2026

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 4, 2026

openshift-ci Bot assigned anuragthehatter, imatza-rh, mhanss, ptalgulk01, rbbratta, sergiordlr and isabella-janssen Jun 4, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026

Conversation

ptalgulk01 commented Jun 4, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 4, 2026

Uh oh!

openshift-ci-robot commented Jun 4, 2026

Uh oh!

coderabbitai Bot commented Jun 4, 2026

Review skipped

Uh oh!

isabella-janssen commented Jun 4, 2026

Uh oh!

openshift-ci-robot commented Jun 4, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 4, 2026

Uh oh!

isabella-janssen commented Jun 4, 2026

Uh oh!

openshift-ci-robot commented Jun 4, 2026

Uh oh!

isabella-janssen left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Jun 4, 2026

Uh oh!

openshift-ci Bot commented Jun 4, 2026

Uh oh!

ptalgulk01 commented Jun 5, 2026

Uh oh!

ptalgulk01 commented Jun 5, 2026

Uh oh!

openshift-ci Bot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci-robot commented Jun 4, 2026 •

edited by openshift-ci Bot

Loading