AGENT-1517: avoid running IRI deletion tests for standard e2e IRI tests

[andfasano]

- What I did
Small fix, followup of #6041, required by openshift/release#79305

Summary by CodeRabbit

No user-visible changes in this release. This update includes internal build configuration adjustments to support different build scenarios.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@andfasano: This pull request references AGENT-1517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

- What I did
Small fix, followup of #6041, required by openshift/release#79305

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 33e8ee74-ea02-45e8-ba64-2befdaedb0ac

📥 Commits

Reviewing files that changed from the base of the PR and between 29cbc3e and b547d0a.

📒 Files selected for processing (1)

• test/e2e-iri/iri_test.go

---

Walkthrough

This PR adds a Go build constraint to test/e2e-iri/iri_test.go that conditionally excludes the entire E2E test file from compilation when the iri_delete build tag is enabled.

Changes

E2E Test Build Constraint

Layer / File(s)	Summary
Build constraint to exclude E2E tests with iri_delete tag test/e2e-iri/iri_test.go	The //go:build !iri_delete constraint is added at the top of the test file, preventing compilation when the iri_delete build tag is set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	New test file adds tests looping through control plane nodes without SNO protection: no [Skipped:SingleReplicaTopology] labels, exutil.IsSingleNode() checks, or topology mode verification.	Add [Skipped:SingleReplicaTopology] labels to test names, or guard with exutil.IsSingleNode()/infrastructure.Status.ControlPlaneTopology checks to skip on SNO.
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	New test file has IPv4-only URL construction patterns (lines 363, 587) using fmt.Sprintf without IPv6 bracket notation for IP addresses.	Use net.JoinHostPort() for URL/address construction or add IPv6 bracket handling to support IPv6-only clusters.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and specifically describes the main change: adding a build constraint to exclude IRI deletion tests from standard e2e IRI test runs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All test names in iri_test.go are stable and deterministic with no dynamic information; PR only adds build constraint without modifying test names.
Test Structure And Quality	✅ Passed	Custom check is for Ginkgo test code. This PR adds a build constraint to standard Go tests using testing.T, not Ginkgo. Check is not applicable.
Microshift Test Compatibility	✅ Passed	PR adds standard Go test functions (testing.T), not Ginkgo tests (It/Describe/Context). The custom check applies only to Ginkgo e2e tests, so this PR is out of scope.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only a test file (test/e2e-iri/iri_test.go) with a build constraint. No deployment manifests, operator code, or controllers were changed, so this check does not apply.
Ote Binary Stdout Contract	✅ Passed	File has no process-level stdout writes: no main(), init(), TestMain(), BeforeSuite() functions. All code respects OTE stdout contract for JSON communication.
No-Weak-Crypto	✅ Passed	Pull request only adds a Go build constraint to exclude a test file from builds. No weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons were introduced.
Container-Privileges	✅ Passed	PR modifies only a Go test file with a build constraint; no container/K8s manifests with privilege settings are present or modified.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds a build constraint to iri_test.go. The one logging statement logs TLS diagnostic output without exposing passwords, tokens, API keys, PII, session IDs, or credentials.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[andfasano]

/test e2e-agent-compact-ipv4-iso-no-registry

[bfournie]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/e2e-iri/OWNERS [andfasano,bfournie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andfasano]

/verified by @andfasano

[openshift-ci-robot]

@andfasano: This PR has been marked as verified by @andfasano.

Details

In response to this:

/verified by @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD dc8e496 and 2 for PR HEAD b547d0a in total

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 62b06d2 and 1 for PR HEAD b547d0a in total

[openshift-ci]

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	b547d0a	link	true	/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.